Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Support arbitrary pnpm versions if metadata is provided manually #1173

Closed
Toxaris opened this issue Jul 24, 2023 · 1 comment · Fixed by #1184 or #1186
Closed

[FR]: Support arbitrary pnpm versions if metadata is provided manually #1173

Toxaris opened this issue Jul 24, 2023 · 1 comment · Fixed by #1184 or #1186
Assignees
@alexeagle
Labels
enhancement New feature or request tech debt Implied cost of additional rework caused by choosing an quick/easy solution earlier untriaged Requires traige

Comments

@Toxaris
Copy link

Toxaris commented Jul 24, 2023 •
edited
Loading

What is the current behavior?

pnpm_repository only supports pnpm versions that have their metadata hard-coded in versions.bzl.

What do we want to achieve?

We have a policy of using the most recent version of dependencies, so we would like to use the most recent release of pnpm before its metadata makes it into a rules_js release.

Describe the feature

Can you add an optional argument to pnpm_repository where we can override the hard-coded metadata dictionary?
@Toxaris Toxaris added the enhancement New feature or request label Jul 24, 2023
@github-actions github-actions bot added the untriaged Requires traige label Jul 24, 2023
@Aghassi Aghassi mentioned this issue Jul 24, 2023
Open
@alexeagle alexeagle self-assigned this Aug 1, 2023
@alexeagle alexeagle added tech debt Implied cost of additional rework caused by choosing an quick/easy solution earlier and removed untriaged Requires traige labels Aug 1, 2023
@alexeagle alexeagle mentioned this issue Aug 2, 2023
Merged
@github-project-automation github-project-automation bot moved this to ✅ Done in Open Source Aug 2, 2023
@alexeagle alexeagle reopened this Aug 2, 2023
@github-actions github-actions bot added the untriaged Requires traige label Aug 2, 2023
@alexeagle alexeagle mentioned this issue Aug 2, 2023
Merged
@alexeagle
Copy link
Member

pnpm_repository now accepts a (version, integrity) tuple for pnpm_version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeagle alexeagle

Labels
enhancement New feature or request tech debt Implied cost of additional rework caused by choosing an quick/easy solution earlier untriaged Requires traige
Projects
Open Source
Archived in project
Milestone
No milestone
2 participants
@alexeagle @Toxaris