Skip to content

Added support for an automatic cache buster suffix on the bg image #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2015
Merged

Added support for an automatic cache buster suffix on the bg image #56

merged 1 commit into from
Mar 12, 2015

Conversation

michaelmoussa
Copy link
Contributor

Folks who use a CDN can append their own cache buster to the .css file, but the background-image entry in the CSS file would still end up being loaded from the browser cache.

This change adds support for a --cachebuster=random parameter, which will append ?<hash> to the background-image: url(...), where <hash> is a randomly generated 40-character hexadecimal string. This would force the new, possibly updated sprite file to be downloaded freshly.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 96.99% when pulling 95842df on michaelmoussa:cache-busting into 00f2db8 on aslansky:master.

aslansky added a commit that referenced this pull request Mar 12, 2015
Added support for an automatic cache buster suffix on the bg image
@aslansky aslansky merged commit 3c06e46 into aslansky:master Mar 12, 2015
@michaelmoussa
Copy link
Contributor Author

Thanks! :)

@michaelmoussa michaelmoussa deleted the cache-busting branch March 12, 2015 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants