Use url.resolve(...) instead of path.join(...) to support abs URLs #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslansky
added a commit
that referenced
this pull request
Mar 11, 2015
Use url.resolve(...) instead of path.join(...) to support abs URLs
|
Sir, thank you very much ;) |
|
You're welcome! Glad to help. Can I trouble you to take a look at #56 as well and tag a release? Looking forward to adding this to our deployment process. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using an absolute url for the
--css-image-path, both in the formhttp://domain.comand//domain.com, which should resolve #48.I've included a test for the new behavior and confirmed the existing tests still pass. Trying to use
http://domain.combefore would result inhttp:/domain.com, which wouldn't work as intended anyway, so there should not be any backwards compatibility issues here.See http://stackoverflow.com/q/16301503/126531 for more information.