Skip to content

fix(conditions): generic condition had exit and init reversed #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2021
Merged

fix(conditions): generic condition had exit and init reversed #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9ac8cc
fix(conditions): generic condition had exit and init reversed
hookSSi Mar 30, 2021
4f5a2a9
Merge branch 'develop' into feature/condition-generic-exit-init-bug
hookSSi Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Assets/FluidBehaviorTree/Runtime/Tasks/Conditions/ConditionGeneric.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ protected override void OnStart () {
}

protected override void OnExit () {
initLogic?.Invoke();
exitLogic?.Invoke();
}

protected override void OnInit () {
exitLogic?.Invoke();
initLogic?.Invoke();
}
}
}
14 changes: 14 additions & 0 deletions Assets/FluidBehaviorTree/Tests/Editor/Tasks/Conditions/ConditionGenericTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,20 @@ public void It_should_execute_a_init_hook () {
Assert.AreEqual(1, test);
}


[Test]
public void It_should_execute_init_hook_before_update () {
var test = 0;
var task = new ConditionGeneric {
initLogic = () => { test++; },
updateLogic = () => { return test == 1; }
};

task.Update();

Assert.AreEqual(task.LastStatus, TaskStatus.Success);
}

[Test]
public void It_should_execute_a_exit_hook () {
var test = 0;
Expand Down