fix(conditions): generic condition had exit and init reversed #54
Conversation
Didn't seem to cause any problems. But would have definitely caused issues with extending the ConditionGeneric class.
|
I wrote a PR according to the guidelines. This is my first experience, so I don't know if I did well. By all means, I would like you to share your opinion with a beginner like me. |
|
@hookSSi this looks solid. I'll pull down the code and verify everything this weekend (would sooner but my job has been a bit crazy this week with a huge upcoming release). I think the test needs to be adjusted slightly to prevent a potential regression. It should be pretty easy to adjust. |
|
@all-contributors please add @hookSSi for code |
|
I've put up a pull request to add @hookSSi! 🎉 |
|
I'm so sorry for that. Thank you for your kind and detailed explanation even in the midst of a busy time. Finally, what I hit wrong "Merge branch'develop' into feature/condition-generic-exit-init-bug" was made. Hope this doesn't make you uncomfortable. |
|
@hookSSi I double checked everything and it all looks great 👍 Feel free to merge. |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Didn't seem to cause any problems. But would have definitely caused issues with extending the
ConditionGeneric class.