Expose Links in Catalog #1184
Merged
Expose Links in Catalog #1184
+210
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
issue-1183-add-links-to-catalog
branch
from
ed322f7
to
03968ff
Compare
Add new Link interface and accessors methods to Catalog interface. Original links in asciidoctor are just a string but here we wrap them in an object to protect from future evolutions. Fixes asciidoctor#1183
|
Awesome! That's great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Expose Links in the Catalog Assest to offer the same features as in core Asciidoctor https://docs.asciidoctor.org/asciidoctor/latest/api/catalog-assets/.
How does it achieve that?
Add new Link interface and accessors methods to Catalog interface.
There are also some improvements to javadocs to ImageReference.
Are there any alternative ways to implement this?
Original links in Asciidoctor are just a string and I could have gone with just that. But I decided to wrap them in an Java interface to protect from future evolutions. I can imagine maybe at some point Link also contain information about the text or attributes being applied in the macro.
Are there any implications of this pull request? Anything a user must know?
No
Issue
Fixes #1183
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc