Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose 'links' from catalog assets #1183

Closed
abelsromero opened this issue Apr 21, 2023 · 2 comments · Fixed by #1184
Closed

Expose 'links' from catalog assets #1183

abelsromero opened this issue Apr 21, 2023 · 2 comments · Fixed by #1184
Labels
enhancement
Milestone
3.0.0

Comments

@abelsromero
Copy link
Member

Reviewing asciidoctor docs I see we are missing links. Adding this property, we'll offer users all the properties of the catalog assets.
@abelsromero abelsromero added this to the 3.0.0 milestone Apr 21, 2023
@abelsromero
Copy link
Member Author

I'll start working on it based on previous images work #1171.

abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Apr 21, 2023
@abelsromero
Expose Links in Catalog
c0bf1bd 
Add new Link interface and accessors methods to Catalog interface.
Original links in asciidoctor are just a string but here we wrap them
in an object to protect from future evolutions.

Fixes asciidoctor#1183
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Apr 21, 2023
@abelsromero
Expose Links in Catalog
ed322f7 
Add new Link interface and accessors methods to Catalog interface.
Original links in asciidoctor are just a string but here we wrap them
in an object to protect from future evolutions.

Fixes asciidoctor#1183
@abelsromero abelsromero mentioned this issue Apr 21, 2023
Merged
5 tasks
@abelsromero
Copy link
Member Author

Internally there are more properties in the catalog, but I'd rather stay on what's being publicly documented.

abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Apr 21, 2023
@abelsromero
Expose Links in Catalog
03968ff 
Add new Link interface and accessors methods to Catalog interface.
Original links in asciidoctor are just a string but here we wrap them
in an object to protect from future evolutions.

Fixes asciidoctor#1183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Expose Links in Catalog abelsromero/asciidoctorj
1 participant
@abelsromero