Repository navigation
Harden releases: pin updates to the signing certificate, tag-only R2 mirror - #2
Merged
Merged
Conversation
Manual Build DMG runs mirrored to R2 and overwrote latest/version.txt. The signing secret checks used a :? form that GitGuardian flagged as a hardcoded password.
A certificate-signed app now requires the downloaded update to satisfy its own designated requirement. Ad-hoc builds have no stable identity to pin and keep the existing signature check, so current installs can still update to the first signed release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-ups from #1.
latest/version.txt, so a test build could become the advertised latest version.Changes
v*tag pushes. Manual runs only upload a workflow artifact.CODESIGN_P12_*checks inbuild-dmg.shandrelease.ymlso they no longer use the${VAR:?message}form.Verification
swift test: 59 tests pass, 1 skipped (the live update test). The newUpdateSignatureTestscovers:LLMits.appmeets the pinned requirement and an ad-hoc re-signed copy is rejected.bash -n scripts/build-dmg.sh, workflow YAML parses, andgit diff --check.