Repository navigation
Defer Keychain access, use agy CLI only, and sign releases with a stable certificate - #1
Merged
Merged
Conversation
…cess Remove the Antigravity Google OAuth flow and the direct read of agy's Keychain item; connecting now verifies the agy login by running its read-only /usage report. Launch no longer probes the Keychain: the saved connection list is trusted and credentials are read only when a connected provider refreshes. Claude and Codex credentials share one cached Keychain item (migrated from the per-provider items), and a denied Keychain prompt is not retried by polling until a manual refresh.
Ad-hoc signatures change the app's designated requirement on every build, so macOS re-prompts for Keychain access after each update. build-dmg.sh now signs with a PKCS#12 identity from CODESIGN_P12_PATH or CODESIGN_P12_BASE64 via a temporary keychain, and tagged releases fail without the signing secrets.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 37595592 | Triggered | Generic Password | c4e19a4 | .github/workflows/release.yml | View secret |
| 37595592 | Triggered | Generic Password | c4e19a4 | scripts/build-dmg.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Launching LLMits showed several Keychain access prompts, and they came back after every update.
start()read the Keychain for every provider, including ones that were never connected, with one Keychain item per provider.gemini/antigravityKeychain item was on by default. That item belongs to agy, so macOS always prompts before LLMits can read it.What changes for users
agy -p /usage. LLMits never reads agy's credentials, so connecting Antigravity never prompts. Existing Google sign-ins switch over to the CLI.identifier "com.llmits.app" and certificate root = H"ad1c6cab…"), so Keychain approval carries over to new versions. Gatekeeper's first-launch warning is unchanged; only a Developer ID fixes that.Existing users will see one last round of prompts on the first signed release, because their items were saved by ad-hoc builds.
Release setup
build-dmg.shsigns with a PKCS#12 identity fromCODESIGN_P12_PATHorCODESIGN_P12_BASE64plusCODESIGN_P12_PASSWORD. It uses a temporary keychain and restores the user's keychain search list afterwards. Without these variables it signs ad-hoc and prints a warning.CODESIGN_P12_BASE64orCODESIGN_P12_PASSWORDsecret is missing. Both are already set on the repository.Verification
swift buildswift test: 56 tests pass, 1 skipped (the live update test). The newCredentialAccessTestscovers: no Keychain reads on a fresh launch, reads limited to connected providers, disconnecting a provider whose credential is missing, no retry after a denied prompt until a manual refresh, connecting Antigravity through the CLI (success and failure), and carrying over an old Google sign-in../scripts/build-dmg.shlocally with both the path and the base64 inputs. Rebuilt with a source change, and the second build met the first build's code identity requirement. Confirmed the keychain search list was restored.git diff --check