Skip to content

feat: add major_version attribute to device initialization #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

feat: add major_version attribute to device initialization #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/blinkstick/devices/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ class BlinkStickDevice(Generic[T]):
variant: BlinkStickVariant = field(init=False)

def __post_init__(self):
Copy link
Preview

Copilot AI Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check to ensure serial_details is not None before accessing major_version to prevent potential AttributeError.

Suggested change
def __post_init__(self):
def __post_init__(self):
if self.serial_details is None:
raise ValueError("serial_details must not be None")

Copilot uses AI. Check for mistakes.

Copy link
Collaborator Author

@robberwick robberwick Feb 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is incorrect. serial_details is a required field of the dataclass, as a default is not provided in the decalration above, andit is not marked with Field(init=False)

self.major_version = self.serial_details.major_version
self.variant = BlinkStickVariant.from_version_attrs(
major_version=self.serial_details.major_version,
version_attribute=self.version_attribute,
Expand Down