feat: add major_version attribute to device initialization #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,7 @@ class BlinkStickDevice(Generic[T]): | |||
| variant: BlinkStickVariant = field(init=False) | |||
|
|
|||
| def __post_init__(self): | |||
There was a problem hiding this comment.
Add a check to ensure serial_details is not None before accessing major_version to prevent potential AttributeError.
Suggested change
| def __post_init__(self): | |
| def __post_init__(self): | |
| if self.serial_details is None: | |
| raise ValueError("serial_details must not be None") |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
this is incorrect. serial_details is a required field of the dataclass, as a default is not provided in the decalration above, andit is not marked with Field(init=False)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes an important change to the
BlinkStickDeviceclass in thesrc/blinkstick/devices/device.pyfile. The change involves initializing themajor_versionattribute in the__post_init__method.src/blinkstick/devices/device.py: Added initialization of themajor_versionattribute in the__post_init__method to ensure it is set based on theserial_detailsof the device.