Skip to content

chore: show content on empty follow option state #12014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Apr 29, 2025

This PR resolves []

Description

this PR adds the follow option picker to the favorites tab.

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • show content on empty follow option state - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri requested a review from dariakoko April 29, 2025 14:13
@MounirDhahri MounirDhahri self-assigned this Apr 29, 2025
@MounirDhahri MounirDhahri added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Apr 29, 2025
@@ -135,7 +137,7 @@ const Content = () => {
}))

return (
<Animated.View style={[animatedStyles, { height: screenHeight + headerHeight }]}>
<Animated.View style={[animatedStyles, { height: screenHeight + headerHeight + space(1) }]}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the issue with the white border

Screen.Recording.2025-04-29.at.16.14.56.mov

@MounirDhahri MounirDhahri removed the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Apr 29, 2025
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (show content on empty follow option state - mounir - MounirDhahri)

Generated by 🚫 dangerJS against 7168b4c

@MounirDhahri MounirDhahri merged commit db6b615 into main Apr 29, 2025
7 checks passed
@MounirDhahri MounirDhahri deleted the fix/show-content-on-empty-state branch April 29, 2025 15:26
MounirDhahri added a commit that referenced this pull request Apr 29, 2025
* chore: show content on empty state

* chore: hide back buttons on follows

(cherry picked from commit db6b615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants