Skip to content

Commit 0dbce7e

Browse files
committed
chore: show content on empty follow option state (#12014)
* chore: show content on empty state * chore: hide back buttons on follows (cherry picked from commit db6b615)
1 parent dcc939c commit 0dbce7e

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

src/app/Scenes/Favorites/Components/FollowedArtists.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export const FollowedArtists: React.FC<Props> = ({ me }) => {
3636
if (data.followsAndSaves?.artistsConnection?.totalCount === 0) {
3737
return (
3838
<Screen.ScrollView refreshControl={RefreshControl}>
39+
<FollowOptionPicker />
3940
<ZeroState
4041
title="You haven’t followed any artists yet"
4142
subtitle="When you’ve found an artist you like, follow them to get updates on new works that become available."
@@ -136,7 +137,7 @@ export const FollowedArtistsQueryRenderer = withSuspense({
136137
return (
137138
<LoadFailureView
138139
onRetry={fallbackProps.resetErrorBoundary}
139-
showBackButton={true}
140+
showBackButton={false}
140141
useSafeArea={false}
141142
error={fallbackProps.error}
142143
trackErrorBoundary={false}

src/app/Scenes/Favorites/Components/FollowedGalleries.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ export const FollowedGalleries: React.FC<Props> = ({ me }) => {
3535
if (galleries.length === 0) {
3636
return (
3737
<Screen.ScrollView refreshControl={RefreshControl}>
38+
<FollowOptionPicker />
3839
<ZeroState
3940
title="You haven’t followed any galleries yet"
4041
subtitle="When you save galleries, they will show up here."
@@ -131,7 +132,7 @@ export const FollowedGalleriesQueryRenderer = withSuspense({
131132
return (
132133
<LoadFailureView
133134
onRetry={fallbackProps.resetErrorBoundary}
134-
showBackButton={true}
135+
showBackButton={false}
135136
useSafeArea={false}
136137
error={fallbackProps.error}
137138
trackErrorBoundary={false}

src/app/Scenes/Favorites/Components/FollowedShows.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export const FollowedShows: React.FC<Props> = ({ me }) => {
3131
if (shows.length === 0) {
3232
return (
3333
<Screen.ScrollView refreshControl={RefreshControl}>
34+
<FollowOptionPicker />
3435
<ZeroState
3536
title="You haven’t saved any shows yet"
3637
subtitle="When you save shows, they will show up here for future use."
@@ -117,7 +118,7 @@ export const FollowedShowsQueryRenderer = withSuspense({
117118
return (
118119
<LoadFailureView
119120
onRetry={fallbackProps.resetErrorBoundary}
120-
showBackButton={true}
121+
showBackButton={false}
121122
useSafeArea={false}
122123
error={fallbackProps.error}
123124
trackErrorBoundary={false}

src/app/Scenes/Favorites/Favorites.tsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
Spacer,
99
Text,
1010
useScreenDimensions,
11+
useSpace,
1112
} from "@artsy/palette-mobile"
1213
import { useScreenScrollContext } from "@artsy/palette-mobile/dist/elements/Screen/ScreenScrollContext"
1314
import { BOTTOM_TABS_HEIGHT } from "@artsy/palette-mobile/dist/elements/Screen/StickySubHeader"
@@ -118,6 +119,7 @@ const FavoritesHeaderTapBar: React.FC<MaterialTopTabBarProps> = ({ state, naviga
118119
export const FavoriteTopNavigator = createMaterialTopTabNavigator()
119120

120121
const Content = () => {
122+
const space = useSpace()
121123
const { currentScrollYAnimated } = useScreenScrollContext()
122124
const { headerHeight } = FavoritesContextStore.useStoreState((state) => state)
123125
const { height: screenHeight } = useScreenDimensions()
@@ -134,7 +136,7 @@ const Content = () => {
134136
}))
135137

136138
return (
137-
<Animated.View style={[animatedStyles, { height: screenHeight + headerHeight }]}>
139+
<Animated.View style={[animatedStyles, { height: screenHeight + headerHeight + space(1) }]}>
138140
<Screen.Body fullwidth>
139141
<FavoriteTopNavigator.Navigator
140142
tabBar={FavoritesHeaderTapBar}

0 commit comments

Comments
 (0)