Skip to content

chore: address design comments on pills #11995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 44 additions & 44 deletions src/app/Scenes/HomeView/Sections/HomeViewSectionNavigationPills.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { ContextModule } from "@artsy/cohesion"
import {
ArtworkIcon,
AuctionIcon as GavelIcon,
FairIcon,
Flex,
FlexProps,
FollowArtistIcon,
AuctionIcon as GavelIcon,
HeartIcon as HeartStrokeIcon,
IconProps,
Pill,
Expand Down Expand Up @@ -59,12 +59,11 @@ export const HomeViewSectionNavigationPills: React.FC<HomeViewSectionNavigationP
{
translateX: withTiming(isSplashScreenVisible ? -150 : 0, {
duration: 1000,
easing: Easing.out(Easing.cubic),
easing: Easing.bezier(0.25, 0.1, 0.25, 1.0),
}),
},
],
// Extra width to be conservative and making sure that we don't have a white section
width: "200%",
overflow: "visible",
}))

if (!navigationPills.length) {
Expand All @@ -73,48 +72,49 @@ export const HomeViewSectionNavigationPills: React.FC<HomeViewSectionNavigationP

return (
<Flex {...flexProps} mt={1}>
<Animated.View style={animatedStyles}>
<FlatList
data={navigationPills}
horizontal
showsHorizontalScrollIndicator={false}
contentContainerStyle={{
<Animated.FlatList
data={navigationPills}
horizontal
showsHorizontalScrollIndicator={false}
style={animatedStyles}
contentContainerStyle={[
{
paddingHorizontal: space(2),
}}
ItemSeparatorComponent={() => <Spacer x={0.5} />}
renderItem={({ item: pill, index }) => (
<RouterLink
hasChildTouchable
to={pill.href}
key={pill.title}
onPress={() => {
tracking.tappedNavigationPillsGroup({
title: pill.title,
href: pill.href,
index: index,
})
}}
},
]}
ItemSeparatorComponent={() => <Spacer x={0.5} />}
renderItem={({ item: pill, index }) => (
<RouterLink
hasChildTouchable
to={pill.href}
key={pill.title}
onPress={() => {
tracking.tappedNavigationPillsGroup({
title: pill.title,
href: pill.href,
index: index,
})
}}
>
<Pill
accessibilityLabel={pill.title}
accessibilityRole="link"
testID={`pill-${pill.title}`}
variant="link"
Icon={SUPPORTED_ICONS[pill.icon as string]}
>
<Pill
accessibilityLabel={pill.title}
accessibilityRole="link"
testID={`pill-${pill.title}`}
variant="link"
Icon={SUPPORTED_ICONS[pill.icon as string]}
>
<Text variant="xs" color="mono100">
{pill.title}
</Text>
</Pill>
</RouterLink>
)}
/>

<HomeViewSectionSentinel
contextModule={section.contextModule as ContextModule}
index={index}
/>
</Animated.View>
<Text variant="xs" color="mono100">
{pill.title}
</Text>
</Pill>
</RouterLink>
)}
/>

<HomeViewSectionSentinel
contextModule={section.contextModule as ContextModule}
index={index}
/>
</Flex>
)
}
Expand Down