Skip to content

chore: address design comments on pills #11995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

chore: address design comments on pills #11995

merged 1 commit into from
Apr 25, 2025

Conversation

MounirDhahri
Copy link
Member

Description

This PR comes to address some comments from Barney about the animation and its duration and behavior

Screen.Recording.2025-04-25.at.12.13.08.mov

PR Checklist

  • I have tested my changes on the following platforms:
    • Android.
    • iOS.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos at least on Android, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

#nochangelog

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Apr 25, 2025
@MounirDhahri MounirDhahri added Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green and removed Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green labels Apr 25, 2025
@ArtsyOpenSource
Copy link
Contributor

Warnings
⚠️

✅ No changelog changes

Generated by 🚫 dangerJS against 5a8a20b

olerichter00
olerichter00 approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@MounirDhahri MounirDhahri merged commit a0058aa into main Apr 25, 2025
7 checks passed
@MounirDhahri MounirDhahri deleted the chore/address-navigation-pills-review-comments branch April 25, 2025 12:58
olerichter00 pushed a commit that referenced this pull request Apr 29, 2025
@MounirDhahri @olerichter00
chore: address design comments on pills (#11995)
1cb4c21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olerichter00 olerichter00 olerichter00 approved these changes

@dariakoko dariakoko Awaiting requested review from dariakoko

Assignees

@MounirDhahri MounirDhahri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MounirDhahri @ArtsyOpenSource @olerichter00