Skip to content

Conversation

@danielknell
Copy link
Member

Fixes #83

Description

Removes superfluous calls to binder.bind() that was causing a crash when the module was used a second time.

Motivation and Context

Fixes an unforeseen error case with the injector integration.

How Has This Been Tested?

Additional unit tests were added and manual poking.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danielknell danielknell enabled auto-merge (squash) November 23, 2023 17:22
@danielknell danielknell force-pushed the issue-83 branch 3 times, most recently from 404e70b to 73c9d53 Compare November 23, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Injector module breaks when used a second time.

2 participants