fix: allow multiple uses of injector module in a single python process

Author: danielknell

.dictionary

@@ -3,6 +3,7 @@ cls
 composable
 configurationerror
 iterable
+lineno
 mypy
 pragma
 py

src/banshee/extra/injector.py

@@ -92,11 +92,6 @@ def __init__(self, registry: banshee.Registry | None = None) -> None:
         self.registry = registry
 
     def configure(self, binder: injector.Binder) -> None:
-        binder.bind(injector.inject(banshee.IdentityMiddleware))
-        binder.bind(injector.inject(banshee.CausationMiddleware))
-        binder.bind(injector.inject(banshee.HandleAfterMiddleware))
-        binder.bind(injector.inject(banshee.DispatchMiddleware))
-
         if self.registry:
             # https://github.com/python/mypy/issues/4717
             binder.bind(
@@ -109,15 +104,11 @@ def configure(self, binder: injector.Binder) -> None:
     @injector.singleton
     @injector.provider
     def _provide_factory(self, container: injector.Injector) -> banshee.HandlerFactory:
-        # pylint: disable=no-self-use
-
         return InjectorHandlerFactory(container)
 
     @injector.singleton
     @injector.provider
     def _provide_message_bus(self, container: injector.Injector) -> banshee.Bus:
-        # pylint: disable=no-self-use
-
         return (
             banshee.Builder()
             .with_middleware(container.get(banshee.IdentityMiddleware))

src/banshee/message.py

@@ -145,7 +145,7 @@ def message_for(
     :returns: a message for the request and context objects
     """
     if not isinstance(request, Message):
-        return Message(request, contexts=tuple(contexts) if contexts else tuple())
+        return Message(request, contexts=tuple(contexts) if contexts else ())
 
     if not contexts:
         return request
@@ -213,6 +213,7 @@ def __init__(self, iterator: collections.abc.Iterator[Middleware]) -> None:
         self.iterator = iterator
 
     async def _final(self, message: Message[T], handle: HandleMessage) -> Message[T]:
+        # pylint: disable=unused-argument
         return message
 
     async def __call__(self, message: Message[T]) -> Message[T]:

tests/unit/test_injector_banshee_module.py

@@ -0,0 +1,33 @@
+"""
+Tests for :class:`banshee.extra.injector.BansheeModule`
+"""
+
+import injector
+
+import banshee
+import banshee.extra.injector
+
+
+def test_it_should_build_bus_instance() -> None:
+    """
+    it should build bus instance.
+    """
+    registry = banshee.Registry()
+    container = injector.Injector(banshee.extra.injector.BansheeModule(registry))
+    bus = container.get(banshee.Bus)  # type: ignore
+
+    assert isinstance(bus, banshee.Bus)
+
+
+def test_it_should_allow_multiple_uses() -> None:
+    """
+    it should allow multiple uses.
+    """
+    registry = banshee.Registry()
+    container = injector.Injector(banshee.extra.injector.BansheeModule(registry))
+    bus1 = container.get(banshee.Bus)  # type: ignore
+
+    container = injector.Injector(banshee.extra.injector.BansheeModule(registry))
+    bus2 = container.get(banshee.Bus)  # type: ignore
+
+    assert bus1 is not bus2