Transaction depends on server type

[Olegt0rr]

Fixes #86
Fixes #87 (added it here as it interfered with the implementation)

[codecov]

Codecov Report

Merging #89 (113903f) into master (dfa023c) will decrease coverage by 2.07%.
The diff coverage is 53.12%.

@@             Coverage Diff             @@
##            master      #89      +/-   ##
===========================================
- Coverage   100.00%   97.92%   -2.08%     
===========================================
  Files           12       12              
  Lines          883      914      +31     
  Branches       143      152       +9     
===========================================
+ Hits           883      895      +12     
- Misses           0       13      +13     
- Partials         0        6       +6     

Flag	Coverage Δ
tests-3.6-4	97.01% <53.12%> (-2.07%)	⬇️
tests-3.6-4.2	97.01% <53.12%> (-2.07%)	⬇️
tests-3.6-4.4	97.01% <53.12%> (-2.07%)	⬇️
tests-3.7-4	96.46% <53.12%> (-2.05%)	⬇️
tests-3.7-4.2	96.46% <53.12%> (-2.05%)	⬇️
tests-3.7-4.4	96.46% <53.12%> (-2.05%)	⬇️
tests-3.8-4	96.28% <53.12%> (-2.03%)	⬇️
tests-3.8-4.2	96.28% <53.12%> (-2.03%)	⬇️
tests-3.8-4.4	96.28% <53.12%> (-2.03%)	⬇️
tests-3.9-4	96.17% <53.12%> (-2.02%)	⬇️
tests-3.9-4.2	96.17% <53.12%> (-2.02%)	⬇️
tests-3.9-4.4	96.17% <53.12%> (-2.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
odmantic/engine.py	89.83% <53.12%> (-10.17%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa023c...113903f. Read the comment docs.

[Olegt0rr]

@art049 , need help!
To cover tests we need different types of mongo servers. I don't know how to implement it.

[art049]

I will add a new element in the CI array so we can test remotely as well on replicasets and sharded clusters 😄

It would probably be helpful to be able to try it locally as well, an easy way would be to add a new task command to launch a dockerized mongo with other settings instead of the standalone one (keeping both of them):

odmantic/Taskfile.yml

Lines 18 to 23 in 5756ddb

	mongodb:docker:
	cmds:
	- echo "Starting odmantic-mongo-test mongo container"
	- docker run --rm -p 27017:27017 --name odmantic-mongo-test -d mongo:4
	status:
	- docker container inspect odmantic-mongo-test

I think we could just create a one member replicaset (basically simply adding --replSet repl-set to the run options)

For testing with mongos locally, it might be more difficult but i will have a look into it.

[art049]

@Olegt0rr I finally merged #91 ! Sorry for the delay but at least now it should be possible for you to configure the new tests :).
Tell me if you need some help to figure out the testing !

[Olegt0rr]

@Olegt0rr I finally merged #91 ! Sorry for the delay but at least now it should be possible for you to configure the new tests :).
Tell me if you need some help to figure out the testing !

I'm not sure I can figure it out.
Busy now + bad in testing
Can you help to cover it?

[art049]

Yes, sure no problem. Thanks for letting me know 😉

[art049]

Transfered to #117. Thanks @Olegt0rr for the inital work.