Skip to content

Comments

Fix transaction depending on server type#117

Open
art049 wants to merge 20 commits intomasterfrom
transaction-fix
Open

Fix transaction depending on server type#117
art049 wants to merge 20 commits intomasterfrom
transaction-fix

Conversation

@art049
Copy link
Owner

@art049 art049 commented Mar 15, 2021

Continuing the initial work done in #89 by @Olegt0rr .

Fixes #86
Fixes #87 (added it here as it interfered with the implementation)

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #117 (dffa91d) into master (7a8430c) will decrease coverage by 0.25%.
The diff coverage is 81.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #117      +/-   ##
===========================================
- Coverage   100.00%   99.74%   -0.26%     
===========================================
  Files           38       38              
  Lines         2723     2760      +37     
  Branches       178      187       +9     
===========================================
+ Hits          2723     2753      +30     
- Misses           0        4       +4     
- Partials         0        3       +3     
Flag Coverage Δ
tests-3.6-4-standalone 99.01% <59.45%> (-0.70%) ⬇️
tests-3.6-4.2-standalone 99.01% <59.45%> (-0.70%) ⬇️
tests-3.6-4.4-standalone 99.01% <59.45%> (-0.70%) ⬇️
tests-3.7-4-standalone 98.82% <59.45%> (-0.69%) ⬇️
tests-3.7-4.2-standalone 98.82% <59.45%> (-0.69%) ⬇️
tests-3.7-4.4-standalone 98.82% <59.45%> (-0.69%) ⬇️
tests-3.8-4-replicaSet 97.46% <62.16%> (-0.48%) ⬇️
tests-3.8-4-standalone 98.76% <59.45%> (-0.69%) ⬇️
tests-3.8-4.2-sharded 97.46% <62.16%> (-0.48%) ⬇️
tests-3.8-4.2-standalone 98.76% <59.45%> (-0.69%) ⬇️
tests-3.8-4.4-standalone 98.76% <59.45%> (-0.69%) ⬇️
tests-3.9-4-standalone 98.65% <59.45%> (-0.68%) ⬇️
tests-3.9-4.2-standalone 98.65% <59.45%> (-0.68%) ⬇️
tests-3.9-4.4-standalone 98.65% <59.45%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/engine.py 96.25% <77.41%> (-3.75%) ⬇️
tests/integration/test_engine.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8430c...dffa91d. Read the comment docs.

@github-actions
Copy link
Contributor

🚀 Deployed on https://docs-preview-117--odmantic.netlify.app

@art049 art049 force-pushed the master branch 2 times, most recently from 5bd1656 to a99a258 Compare November 3, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modified mark is not cleared for embedded models on save 🔴 Transactions are not used now!

2 participants