Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize requirements file throughout codebase #978

Merged
merged 1 commit into from
May 16, 2021
Merged

Conversation

jadchaar
Copy link
Member

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Closes: #926
Follows format of requests: https://github.com/psf/requests/blob/master/requirements-dev.txt.

Changed references from requirements.txt to requirements-dev.txt throughout the code base, changed wildcard versioning in requirements, and upped dependency versions.

@jadchaar jadchaar changed the title Re-organize requirements.txt file Reorganize requirements file throughout codebase May 16, 2021
@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #978 (12ba2ad) into master (05c1a1a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #978   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2054      2054           
  Branches       330       330           
=========================================
  Hits          2054      2054           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c1a1a...12ba2ad. Read the comment docs.

Copy link
Member

@anishnya anishnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jadchaar jadchaar merged commit 119bb67 into master May 16, 2021
@jadchaar jadchaar deleted the requirements branch May 16, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break down requirements.txt into separate files
2 participants