Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename requirements.txt to requirements_dev.txt #957

Closed
wants to merge 1 commit into from

Conversation

systemcatch
Copy link
Collaborator

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Idea for avoiding confusion with our install requirements, happy to take suggestions for other ways to do this though.

fixes #926

@jadchaar
Copy link
Member

We may want to create a requirements folder and have a few requirements.txt files inside of them: requirements-dev.txt and requirements-docs.txt.

@systemcatch
Copy link
Collaborator Author

We may want to create a requirements folder and have a few requirements.txt files inside of them: requirements-dev.txt and requirements-docs.txt.

We could do that but is it worth it for only 10 packages? Happy to change to that though if you prefer.

@jadchaar
Copy link
Member

We may want to create a requirements folder and have a few requirements.txt files inside of them: requirements-dev.txt and requirements-docs.txt.

We could do that but is it worth it for only 10 packages? Happy to change to that though if you prefer.

I think it is worthwhile for organizational purposes. We'd need to also adjust the tox.ini and Makefile since that is where we call pip install -r requirements.txt.

@jadchaar
Copy link
Member

Updated and replaced with #978.

@jadchaar jadchaar closed this May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break down requirements.txt into separate files
2 participants