ClojureScript 1.10.145 #209
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the patch files accordingly.
In particular there is no need for munging of the paths to the cache anymore. This also disables (with explanation) a write cache test because there seems to be an error with namespaces that we skip loading.
arichiardi
force-pushed
the
cljs-1-10-145
branch
3 times, most recently
from
7cac0be to
f2cc345
Compare
arichiardi
force-pushed
the
cljs-1-10-145
branch
from
f2cc345 to
db70103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a while I decided to give a go to an upgrade.
Some tests are still not passing but they are mainly due to upstream fixes we had tests against.
There is also probably a bug with writing cache with skipped namespaces like
clojure.setsomewhere.Needs more work.