Issue detecting test namespaces

[arichiardi]

I am having some issue in the replumb project with the runner.

Basically when I display the classpath, I see the folders there:

$ clojure -Srepro -A:dev:test:node -Spath
test/common:src/node:repl-demo/node/cljs:test/node:src/cljs:test/common:...

but the runner does only:

$ ./scripts/test
+ export NODE_ENV=dev
+ NODE_ENV=dev
+ output_dir=.cljs-test-runner
+ main_cmd='clojure -Srepro -A:dev:test:node -m cljs-test-runner.main -V  --out .cljs-test-runner  --env node'
+ watch_args=
+ [[ '' =~ --watch ]]
+ main_cmd+=' '
+ main_cmd+=' --namespace replumb.cache-test'
+ clojure -Srepro -A:dev:test:node -m cljs-test-runner.main -V --out .cljs-test-runner --env node --namespace replumb.cache-test
Options passed to ClojureScript compiler: {:output-dir ".cljs-test-runner", :closure-warnings {:check-types :off, :check-variables :off}, :closure-defines {"cljs.core._STAR_target_STAR_" "nodejs"}, :ups-libs nil, :cache-analysis true, :closure-module-roots [], :optimizations :none, :ups-foreign-libs [], :verbose true, :aot-cache false, :ignore-js-module-exts [".css"], :output-to ".cljs-test-runner/test-runner.js", :preamble ["cljs/imul.js"], :ups-externs nil, :opts-cache "cljsc_opts.edn", :source-map true, :cache-analysis-format :transit, :target :nodejs, :main test.runner, :emit-constants nil}
Copying jar:file:/home/arichiardi/.m2/repository/org/clojure/core.rrb-vector/0.0.11/core.rrb-vector-0.0.11.jar!/clojure/core/rrb_vector/protocols.cljs to .cljs-test-runner/clojure/core/rrb_vector/protocols.cljs
Reading analysis cache for jar:file:/home/arichiardi/.m2/repository/org/clojure/clojurescript/1.10.339/clojurescript-1.10.339.jar!/cljs/core.cljs
Compiling .cljs-test-runner/clojure/core/rrb_vector/protocols.cljs to .cljs-test-runner/clojure/core/rrb_vector/protocols.js

I wonder what it is going wrong, the classpath is built correctly. It might be something very silly on my end and the runner works in other projects with aliases.

[Olical]

Hmm, I wonder if this has something to do with the namespace filtering? Probably not, but worth trying to isolate this. I can't see anything wrong with your usage right now but I am pretty tired heading home from a music festival, so take my opinion with a pinch of salt 😅

Would you maybe be able to push your branch of replumb somewhere so we can isolate the root cause easier?

[Olical]

Oh, maybe try specifying --dir (-d), you can specify multiple like -d x -d y. Although if everything is already in your test directory maybe it won't make a difference.

[arichiardi]

I will publish and try those suggestions for sure.

[arichiardi]

I have pushed my branch to arichiardi/replumb#209.

The output is a bit verbose but you can try: ./scripts/test --watch -r .*cache.* - it should not test anything but .replumb.cache-test

[arichiardi]

it seems like a different problem from the original issue though, maybe I can open a new one?

[Olical]

Tried it myself, looks like --namespace-regex combined with --watch is the issue. The regex is ignored when watching.

[Olical]

Haha, I've found it. test/node/test/runner.cljs and test/browser/test/runner.cljs contain calls to doo-tests at their top level, so as the file is read it's executed. The files are loaded by cljs/watch as part of it's watching system (not sure what we can do about that?...). If you remove the files everything works as expected.

[Olical]

@arichiardi ping, just in case you don't see these comments since it's an old thread. I hope things are going well for you 😄

[Olical]

Will be closing this for now (having an issue clear out if you haven't noticed 😬 the number of them across various repos was stressing me out). If it's still an issue and we can reliably reproduce it I'll take another look.

I think this was an issue with the specific project as I mentioned in my previous comment though.

[arichiardi]

Ok no problem I will check replumb again and reopen in case 😉