Skip to content

Disallow empty source name in standard json #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
axic wants to merge 1 commit into from
Closed

Disallow empty source name in standard json #2729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libsolidity/interface/StandardCompiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ Json::Value StandardCompiler::compileInternal(Json::Value const& _input)
{
string hash;

if (sourceName.empty())
return formatFatalError("JSONError", "Source name cannot be empty.");

if (!sources[sourceName].isObject())
return formatFatalError("JSONError", "Source input is not a JSON object.");

Expand Down
16 changes: 16 additions & 0 deletions test/libsolidity/StandardCompiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,22 @@ BOOST_AUTO_TEST_CASE(smoke_test)
BOOST_CHECK(containsAtMostWarnings(result));
}

BOOST_AUTO_TEST_CASE(empty_source_name)
{
char const* input = R"(
{
"language": "Solidity",
"sources": {
"": {
"content": ""
}
}
}
)";
Json::Value result = compile(input);
BOOST_CHECK(containsError(result, "JSONError", "Source name cannot be empty."));
}

BOOST_AUTO_TEST_CASE(basic_compilation)
{
char const* input = R"(
Expand Down