Skip to content

Disallow empty source name in standard json#2729

Closed
axic wants to merge 1 commit intodevelopfrom
jsonio-empty-name
Closed

Disallow empty source name in standard json#2729
axic wants to merge 1 commit intodevelopfrom
jsonio-empty-name

Conversation

@axic
Copy link
Contributor

@axic axic commented Aug 10, 2017

No description provided.

@axic
Copy link
Contributor Author

axic commented Aug 11, 2017

The reason for this change was that outputSelection would be confused, because empty source name refers to SourceUnit-level outputs (aka AST).

However, jsonCompiler needs to be amended, because the old compile() entry point has only a source code and uses an empty file name. The same applies to compileJSON() it allows empty file names. (Need to add test for this in solc-js just to be sure too.)

@chriseth
Copy link
Contributor

What is the state of this PR?

@axic
Copy link
Contributor Author

axic commented Oct 17, 2017

jsonCompiler needs to be reviewed how it fits in for the legacy use cases as there it might require right now the use of an empty file name.

I also have another change set which cleans this up in CompilerStack.

@axic
Copy link
Contributor Author

axic commented Oct 20, 2017

The reason for this change was that outputSelection would be confused, because empty source name refers to SourceUnit-level outputs (aka AST).

Revisited this again and empty source name is not an issue, empty contract name is.

@axic axic closed this Oct 20, 2017
@axic axic deleted the jsonio-empty-name branch October 24, 2017 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants