Little enhancements to the ppa release script #13370
Conversation
Marenz
force-pushed
the
ppa_release_fixes
branch
2 times, most recently
from
1703198 to
bc4c53f
Compare
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
At your service. I humbly report that the pull request is 90% cromulent.
|
As for the checklist, yeah, we should update it but it would be best to merge #13363 first. |
Marenz
force-pushed
the
ppa_release_fixes
branch
2 times, most recently
from
4494553 to
7480b9e
Compare
cameel
left a comment
cameel
left a comment
There was a problem hiding this comment.
A few more suggestions, though nothing critical. Not approving yet only because of the checklist.
Marenz
force-pushed
the
ppa_release_fixes
branch
from
7480b9e to
1796bce
Compare
ekpyron
left a comment
ekpyron
left a comment
There was a problem hiding this comment.
Still looks good to me :-).
scripts/release_ppa.sh
Outdated
| if [[ -e .release_ppa_auth ]] | ||
| then | ||
| # shellcheck source=/dev/null | ||
| source ${REPO_ROOT}/.release_ppa_auth |
There was a problem hiding this comment.
Ha, I saw it before the CI run complaining about it failed :-D.
Marenz
force-pushed
the
ppa_release_fixes
branch
from
1796bce to
0fab970
Compare
|
@ekpyron this one seems good to go? |
It's waiting for #13363, since it'll require to change the release checklist as well (just doesn't do that right away, since it'd only result in conflicts anyways). That being said, since #13363 is not merged yet and this can be, we can merge here and adjust there. |
No description provided.