Release checklist update and tweaks after 0.8.16 #13363

cameel · 2022-08-08T16:22:09Z

Some tweaks to the checklist based on our experience with this release.

Docs get built automatically so looks like we no longer need separate steps for RTD. We should verify that with @chriseth though.
In practice we never run full tests.sh. I updated that point to say only to run the buglist update script.
Clarification regarding changelog and version commits.
Warning on the release page and more detailed steps for blog posts.

ReleaseChecklist.md

franzihei

Added some details re. communications

ReleaseChecklist.md

ekpyron

Some nitpicking comments :-). But we can also just merge.

ekpyron · 2022-08-10T16:09:58Z

ReleaseChecklist.md

 - [ ] Lauchpad (Ubuntu One) account
- - [ ] gnupg key (has to be version 1, gpg2 won't work) for `your-name@ethereum.org` created and uploaded
- - [ ] Readthedocs account, access to the Solidity project
+ - [ ] gnupg key (has to be version 1, gpg2 won't work) for ``your-name@ethereum.org`` created and uploaded


Not entire clear what to do with that key... i.e. we could merge this with the previous point (Are gpg keys required for anything but launchpad? Nothing comes to my mind.)

Good point. I think that's the only thing. Unless dockerhub also requires it (I don't have access to that) but I doubt it.

While at it I also added other requirements: all repos, npm, dockerhub, twitter, reddit, etc. Check it out.

I mean, if enough ppl have keys, we could start signing our commits?

(just thinking about other cases where they are useful)

Probably. I wonder how that works with rebases though. Doesn't this invalidate signatures?

I think the sentiment in the past was that signed commits aren't really all that useful in general :-).

ReleaseChecklist.md

cameel · 2022-08-11T12:54:27Z

ReleaseChecklist.md

+ - [ ] Github account with access to [solidity](https://github.com/ethereum/solidity), [solc-js](https://github.com/ethereum/solc-js),
+       [solc-bin](https://github.com/ethereum/solc-bin), [homebrew-ethereum](https://github.com/ethereum/homebrew-ethereum),
+       [solidity-blog](https://github.com/ethereum/solidity-blog) and [solidity-portal](https://github.com/ethereum/solidity-portal) repositories.
+ - [ ] DockerHub account with push rights to the [``solc`` image](https://hub.docker.com/r/ethereum/solc).


I don't have dockerhub account so not sure how that works in details. Do you need access to a specific image or do you just need to be a member of the ethereum organization?

I think being part of the ethereum organization is sufficient. But ultimately what you happens is that you'll push the solc image, so I'd say the current phrasing is fine.

ekpyron · 2022-08-12T10:00:27Z

I just merged #13370, so would be nice to tweak the checklist for that here as well.

cameel · 2022-08-16T11:01:55Z

ReleaseChecklist.md

+ - [ ] Create ``.release_ppa_auth`` at the root of your local Solidity checkout and set ``LAUNCHPAD_EMAIL`` and ``LAUNCHPAD_KEYID`` to your key's email and key id.
+ - [ ] Double-check that the ``DISTRIBUTIONS`` list in ``scripts/release_ppa.sh`` and ``scripts/deps-ppa/static-z3.sh`` contains the most recent versions of Ubuntu.
+ - [ ] Make sure the [``~ethereum/cpp-build-deps`` PPA repository](https://launchpad.net/~ethereum/+archive/ubuntu/cpp-build-deps) contains ``libz3-static-dev builds`` for all current versions of Ubuntu.
+       If not, run ``scripts/deps-ppa/static-z3.sh`` (after changing email address and key id) and wait for the builds to succeed before continuing.


@Marenz I just realized that #13370 did not cover scripts/deps-ppa/static-z3.sh so it still has a hard-coded key and e-mail. I think we should have them both working the same way.

cameel · 2022-08-16T11:02:51Z

ReleaseChecklist.md

+ - [ ] Double-check that the ``DISTRIBUTIONS`` list in ``scripts/release_ppa.sh`` and ``scripts/deps-ppa/static-z3.sh`` contains the most recent versions of Ubuntu.
+ - [ ] Make sure the [``~ethereum/cpp-build-deps`` PPA repository](https://launchpad.net/~ethereum/+archive/ubuntu/cpp-build-deps) contains ``libz3-static-dev builds`` for all current versions of Ubuntu.
+       If not, run ``scripts/deps-ppa/static-z3.sh`` (after changing email address and key id) and wait for the builds to succeed before continuing.
 - [ ] Run ``scripts/release_ppa.sh v$VERSION`` to create the PPA release (you need the relevant openssl key).


@Marenz What key is it referencing? Does it mean GPG key or did you actually need some OpenSSL key here?

Yeah, I am not sure what ssl keys are meant here, as far as I know I only needed the gpg keys registered with launchpad

OK, I'm removing this bit in that case.

ReleaseChecklist.md

mistakenly approved early

matheusaaguiar

I noticed that there are 3 "raw" urls in the text while others were wrapped in hyperlinks. Probably we want to do this with these remaining ones.

ReleaseChecklist.md

…the whole tests.sh

…e page a single point

…ndents and mismatched parentheses

…d use long options

cameel requested review from Marenz, chriseth, ekpyron and franzihei August 8, 2022 16:22

cameel self-assigned this Aug 8, 2022

cameel commented Aug 8, 2022

View reviewed changes

ReleaseChecklist.md Show resolved Hide resolved

ekpyron reviewed Aug 8, 2022

View reviewed changes

ReleaseChecklist.md Show resolved Hide resolved

ekpyron reviewed Aug 8, 2022

View reviewed changes

ReleaseChecklist.md Outdated Show resolved Hide resolved

cameel dismissed a stale review via 5073ecd August 9, 2022 08:57

cameel force-pushed the release-checklist-update-and-tweaks branch from 6a9e706 to 5073ecd Compare August 9, 2022 08:57

cameel dismissed a stale review via 4454201 August 9, 2022 09:26

cameel force-pushed the release-checklist-update-and-tweaks branch 3 times, most recently from bba4711 to 9b4ab06 Compare August 9, 2022 09:42

ekpyron reviewed Aug 9, 2022

View reviewed changes

ReleaseChecklist.md Show resolved Hide resolved

franzihei reviewed Aug 9, 2022

View reviewed changes

ReleaseChecklist.md Outdated Show resolved Hide resolved

ReleaseChecklist.md Outdated Show resolved Hide resolved

ReleaseChecklist.md Outdated Show resolved Hide resolved

ReleaseChecklist.md Show resolved Hide resolved

ReleaseChecklist.md Outdated Show resolved Hide resolved

cameel force-pushed the release-checklist-update-and-tweaks branch from 9b4ab06 to 5b90dd3 Compare August 9, 2022 12:56

cameel added the documentation 📖 label Aug 10, 2022

cameel requested a review from nikola-matic August 10, 2022 13:31

cameel mentioned this pull request Aug 10, 2022

Little enhancements to the ppa release script #13370

Merged

ekpyron previously approved these changes Aug 10, 2022

View reviewed changes

cameel dismissed ekpyron’s stale review via 8d400dd August 11, 2022 12:43

cameel force-pushed the release-checklist-update-and-tweaks branch 6 times, most recently from 2f900fc to b3af578 Compare August 11, 2022 12:51

cameel commented Aug 11, 2022

View reviewed changes

cameel dismissed a stale review via b27c521 August 16, 2022 10:54

cameel force-pushed the release-checklist-update-and-tweaks branch 4 times, most recently from 02b7025 to 510300d Compare August 16, 2022 10:58

cameel commented Aug 16, 2022

View reviewed changes

ReleaseChecklist.md Show resolved Hide resolved

cameel force-pushed the release-checklist-update-and-tweaks branch from 510300d to 262617b Compare August 24, 2022 18:25

matheusaaguiar previously approved these changes Aug 24, 2022

View reviewed changes

cameel added the priority review We want this get the review of this PR to a conclusion ASAP. label Aug 25, 2022

matheusaaguiar reviewed Aug 25, 2022

View reviewed changes

ReleaseChecklist.md Outdated Show resolved Hide resolved

ReleaseChecklist.md Outdated Show resolved Hide resolved

cameel added 10 commits September 5, 2022 18:13

ReleaseChecklist: Documentation now gets built automatically from tags

71a9fb2

ReleaseChecklist: Regenerating the bug list does not require running …

dd2f718

…the whole tests.sh

ReleaseChecklist: More detailed steps related to blog posts

b9d06b4

ReleaseChecklist: Emphasize separate changelog and version commits

3f437da

ReleaseChecklist: Add "still in progress" warning and make the releas…

3388305

…e page a single point

ReleaseChecklist: Consistently use double backticks everywhere, fix i…

d9f169e

…ndents and mismatched parentheses

ReleaseChecklist: Don't sort contributor list by number of commits an…

f5c91ec

…d use long options

ReleaseChecklist: Update the list of requirements

be67e76

ReleaseChecklist: Update PPA instructions

98ad27d

ReleaseChecklist: Markdown formatting for all links

ccc3317

cameel force-pushed the release-checklist-update-and-tweaks branch from 262617b to ccc3317 Compare September 5, 2022 16:20

cameel requested review from ekpyron and matheusaaguiar September 5, 2022 16:20

matheusaaguiar approved these changes Sep 5, 2022

View reviewed changes

ekpyron approved these changes Sep 5, 2022

View reviewed changes

ekpyron merged commit 62e4ce3 into develop Sep 5, 2022

ekpyron deleted the release-checklist-update-and-tweaks branch September 5, 2022 17:00

Release checklist update and tweaks after 0.8.16 #13363

Release checklist update and tweaks after 0.8.16 #13363

Uh oh!

Conversation

cameel commented Aug 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

franzihei left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ekpyron left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cameel Aug 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ekpyron commented Aug 12, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matheusaaguiar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cameel commented Aug 8, 2022 •

edited

Loading

franzihei left a comment •

edited

Loading

cameel Aug 11, 2022 •

edited

Loading