Skip to content

Tiny refactors in external tests and scripts #12259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2021
Merged

Tiny refactors in external tests and scripts #12259

merged 3 commits into from
Nov 8, 2021

Conversation

@cameel
Copy link
Collaborator

@cameel cameel commented Nov 8, 2021

This was originally a part of #12191, extracted into a separate PR as suggested by @axic.

  • Consistent style for Bash function declarations.
  • set -e in external tests.
  • Named temporary dirs in external tests so that it's easier to locate the results in /tmp/.

@cameel cameel requested a review from axic November 8, 2021 15:36
@cameel cameel self-assigned this Nov 8, 2021
@cameel cameel mentioned this pull request Nov 8, 2021
Merged
@chriseth chriseth enabled auto-merge November 8, 2021 15:47
@chriseth chriseth merged commit fe6e58b into develop Nov 8, 2021
@chriseth chriseth deleted the external-tests-and-scripts-minor-reactors branch November 8, 2021 16:21
@cameel cameel mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@axic axic axic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cameel cameel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cameel @axic @chriseth