Bytecode comparison PR check #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
bytecode-comparison-pr-check
branch
from
4b8e5f4 to
2cf7b24
Compare
cameel
changed the base branch from
fix-version-string-in-macosx-build-action
to
gh-pages
cameel
force-pushed
the
bytecode-comparison-pr-check
branch
from
2cf7b24 to
2e45b87
Compare
cameel
changed the base branch from
gh-pages
to
fix-version-string-in-macosx-build-action
cameel
force-pushed
the
bytecode-comparison-pr-check
branch
2 times, most recently
from
7864ece to
805d84a
Compare
Base automatically changed from
fix-version-string-in-macosx-build-action
to
gh-pages
February 2, 2021 14:52
Collaborator
Author
|
argotorg/solidity#10838 has been accepted so this PR is now next in line for review. |
ekpyron
reviewed
Feb 3, 2021
Collaborator
ekpyron
left a comment
ekpyron
left a comment
There was a problem hiding this comment.
LGTM (can be considered as approval once argotorg/solidity#10838 is merged and the refs changed here)
cameel
force-pushed
the
bytecode-comparison-pr-check
branch
from
805d84a to
78924d7
Compare
ekpyron
approved these changes
Feb 4, 2021
Collaborator
|
Merging this before we're getting any more nightlies and need more rebases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #75. Don't merge until that PR is merged! Also depends on argotorg/solidity#10838.
This adds a check that does bytecode comparison on all binaries (except for Windows - that will need to be a separate feature if we want that) in versions that were touched by a PR . Bytecode report is generated by running
isolate_tests.pyandprepare_report.py/prepare_report.jsfrom Solidity'sdevelopbranch on test cases from the tag corresponding to the release version.Warning: The check is currently using scripts from argotorg/solidity#10838 rather than from
develop. This will all be switched back to the correct branches once the PR in solidity repo is merged.