Force remove '.mod' from version string of rebuilt macOS binaries #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2020
cameel
changed the title
cameel
changed the title
…tring when the source contains uncommitted changes - The code won't build without modifications. The only modified things though are tests and elements of the build system.
…uild without cherry-picked commits
cameel
force-pushed
the
fix-macosx-build-action-for-newer-homebrew-and-clang
branch
from
ebb6a00 to
f57c4ca
Compare
cameel
force-pushed
the
fix-version-string-in-macosx-build-action
branch
from
b5cca63 to
6e853b8
Compare
Base automatically changed from
fix-macosx-build-action-for-newer-homebrew-and-clang
to
gh-pages
January 28, 2021 12:50
chriseth
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR branch based on #74. Don't merge until that PR is merged!
This is a direct fix for the issue reported in argotorg/solidity#10183. Siimply cuts out the
.modpart from the version string to make it match the one from the original release. Hopefully that's all that is needed - I'll need to run bytecode comparison to be sure.