Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore endpointslice modified events, and add tests #469

Conversation

fungiboletus
Copy link

Signed-off-by: Antoine Pultier <antoine.pultier@sintef.no>
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (98ccd3d) to head (c89a5a1).
Report is 47 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   55.46%   55.95%   +0.48%     
==========================================
  Files          41       41              
  Lines        4504     4504              
==========================================
+ Hits         2498     2520      +22     
+ Misses       1813     1794      -19     
+ Partials      193      190       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sidewinder12s
Copy link

This would be useful, we have a lot of DaemonSets with services that are causing constant reconciliations due to constant cluster scaling.

@aaemula
Copy link

aaemula commented Jun 2, 2023

This change is awesome.
So we don't have to manually configure the resource.exclusions.

@aaemula
Copy link

aaemula commented Jun 2, 2023

@crenshaw-dev @alexmt @jessesuen PTAL

@diranged
Copy link

diranged commented Feb 9, 2024

What needs to be done to get this over the hump? This has a serious load impact for us (argoproj/argo-cd#15594 (comment)).

Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should hardcode these resources to be ignored by default. It is already possible to configure them via resource.exclusions. Perhaps It is time to provide a default exclusion configuration that includes these resources?

This would allow users the be able to configure the behavior they want, while providing sensible default.

@fungiboletus
Copy link
Author

Is there a scenario where you don't want EndpointSlice to be ignored? I saw the code was ready to add more ignored ressources so I just added it there.

I think it's fine to have default ignored ressources in resource.exclusions instead. I wouldn't mind if someone else feels like implementing it :D

@agaudreault
Copy link
Member

agaudreault commented Sep 19, 2024

@fungiboletus we do have them in the UI because they contain useful networking information to identify and debug some network problems.

I created an issue for the 3.0 version to change the default settings argoproj/argo-cd#20013 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants