-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ignore endpointslice modified events, and add tests #469
feat: ignore endpointslice modified events, and add tests #469
Conversation
Signed-off-by: Antoine Pultier <antoine.pultier@sintef.no>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
==========================================
+ Coverage 55.46% 55.95% +0.48%
==========================================
Files 41 41
Lines 4504 4504
==========================================
+ Hits 2498 2520 +22
+ Misses 1813 1794 -19
+ Partials 193 190 -3 ☔ View full report in Codecov by Sentry. |
…e-modified-events
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This would be useful, we have a lot of DaemonSets with services that are causing constant reconciliations due to constant cluster scaling. |
This change is awesome. |
What needs to be done to get this over the hump? This has a serious load impact for us (argoproj/argo-cd#15594 (comment)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should hardcode these resources to be ignored by default. It is already possible to configure them via resource.exclusions
. Perhaps It is time to provide a default exclusion configuration that includes these resources?
This would allow users the be able to configure the behavior they want, while providing sensible default.
Is there a scenario where you don't want EndpointSlice to be ignored? I saw the code was ready to add more ignored ressources so I just added it there. I think it's fine to have default ignored ressources in |
@fungiboletus we do have them in the UI because they contain useful networking information to identify and debug some network problems. I created an issue for the 3.0 version to change the default settings argoproj/argo-cd#20013 :) |
This is related to a comment stating that endpointslice should be ignored.