Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints not ignored by ArgoCD Application Controller #16023

Closed
3 tasks
sidewinder12s opened this issue Oct 18, 2023 · 1 comment · Fixed by #20014
Closed
3 tasks

Endpoints not ignored by ArgoCD Application Controller #16023

sidewinder12s opened this issue Oct 18, 2023 · 1 comment · Fixed by #20014
Labels
bug Something isn't working

Comments

@sidewinder12s
Copy link

sidewinder12s commented Oct 18, 2023

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

The resource exclusion docs seem to indicate that Endpoints should be excluded/not presented and tracked in ArgoCD: https://argo-cd.readthedocs.io/en/stable/operator-manual/declarative-setup/#resource-exclusioninclusion

I am still seeing them in our ArgoCD UI however.

I've generally been chasing down Application controller perf issues that seem to be rooted in extremely active clusters cause excessive reconciliation triggering. A few of the items that seem to trigger it are Endpoints, EndpointSlices, DaemonSet updates largely driven by cluster autoscaling.

To Reproduce

Deploy a service with endpoints, check UI for endpoints object

Expected behavior

Services should not be tracking the endpoint object.

It appears adding endpoints explicitly to resource.exclusions has them ignored by ArgoCD.

Screenshots

image

Version

argocd: v2.7.14+a40c95a
  BuildDate: 2023-09-07T17:39:29Z
  GitCommit: a40c95a6383baa0d9f670586a5c295021f59337c
  GitTreeState: clean
  GoVersion: go1.19.12
  Compiler: gc
  Platform: linux/amd64
argocd-server: v2.7.14+a40c95a.dirty
  BuildDate: 2023-09-07T16:50:47Z
  GitCommit: a40c95a6383baa0d9f670586a5c295021f59337c
  GitTreeState: dirty
  GoVersion: go1.19.10
  Compiler: gc
  Platform: linux/arm64
  Kustomize Version: v5.0.1 2023-03-14T01:32:48Z
  Helm Version: v3.11.2+g912ebc1
  Kubectl Version: v0.24.2
  Jsonnet Version: v0.19.1

References:

argoproj/gitops-engine#469
#8175

@agaudreault
Copy link
Member

Added to 3.0 milestone with #20013 to change the default configurable settings. The current behavior is expected not to exclude Endpoints by default, but doc was not up-to-date.

agaudreault added a commit that referenced this issue Sep 19, 2024
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants