Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify SuspendTemplate.duration. #9997

Merged
merged 4 commits into from
Nov 15, 2022

Conversation

cjyar
Copy link
Contributor

@cjyar cjyar commented Nov 8, 2022

Fixes #TODO

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems. Yes, but it failed.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Chris Jones <chris.jones@ironcorelabs.com>
@cjyar
Copy link
Contributor Author

cjyar commented Nov 8, 2022

In the online docs, the description implies the field should be an integer, even though the type is string. This PR tries to fix that by making the description clearer. The new description was copied from here.

Signed-off-by: Chris Jones <chris.jones@ironcorelabs.com>
Signed-off-by: Chris Jones <chris.jones@ironcorelabs.com>
@cjyar cjyar marked this pull request as ready for review November 10, 2022 18:49
Copy link
Member

@caelan-io caelan-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the additional clarification throughout.

@terrytangyuan terrytangyuan merged commit 6f76934 into argoproj:master Nov 15, 2022
@cjyar cjyar deleted the suspend-doc-update branch November 16, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants