Skip to content

Commit

Permalink
docs: Clarify SuspendTemplate.duration. (#9997)
Browse files Browse the repository at this point in the history
Signed-off-by: Chris Jones <chris.jones@ironcorelabs.com>
  • Loading branch information
cjyar authored Nov 15, 2022
1 parent fd6aec1 commit 6f76934
Show file tree
Hide file tree
Showing 11 changed files with 17 additions and 13 deletions.
2 changes: 1 addition & 1 deletion api/jsonschema/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -6398,7 +6398,7 @@
"description": "SuspendTemplate is a template subtype to suspend a workflow at a predetermined point in time",
"properties": {
"duration": {
"description": "Duration is the seconds to wait before automatically resuming a template",
"description": "Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds. Could also be a Duration, e.g.: \"2m\", \"6h\", \"1d\"",
"type": "string"
}
},
Expand Down
2 changes: 1 addition & 1 deletion api/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -10302,7 +10302,7 @@
"type": "object",
"properties": {
"duration": {
"description": "Duration is the seconds to wait before automatically resuming a template",
"description": "Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds. Could also be a Duration, e.g.: \"2m\", \"6h\", \"1d\"",
"type": "string"
}
}
Expand Down
3 changes: 2 additions & 1 deletion docs/executor_swagger.md
Original file line number Diff line number Diff line change
Expand Up @@ -4337,7 +4337,8 @@ Namespaces that do not pre-exist within StorageOS will be created.

| Name | Type | Go type | Required | Default | Description | Example |
|------|------|---------|:--------:| ------- |-------------|---------|
| duration | string| `string` | | | Duration is the seconds to wait before automatically resuming a template | |
| duration | string| `string` | | | Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds.
Could also be a Duration, e.g.: "2m", "6h", "1d" | |



Expand Down
2 changes: 1 addition & 1 deletion docs/fields.md
Original file line number Diff line number Diff line change
Expand Up @@ -3137,7 +3137,7 @@ SuspendTemplate is a template subtype to suspend a workflow at a predetermined p
### Fields
| Field Name | Field Type | Description |
|:----------:|:----------:|---------------|
|`duration`|`string`|Duration is the seconds to wait before automatically resuming a template|
|`duration`|`string`|Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds. Could also be a Duration, e.g.: "2m", "6h", "1d"|

## LabelValueFrom

Expand Down
3 changes: 2 additions & 1 deletion pkg/apis/workflow/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/workflow/v1alpha1/openapi_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/apis/workflow/v1alpha1/workflow_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -3062,7 +3062,8 @@ func (t *DAGTask) ShouldExpand() bool {

// SuspendTemplate is a template subtype to suspend a workflow at a predetermined point in time
type SuspendTemplate struct {
// Duration is the seconds to wait before automatically resuming a template
// Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds.
// Could also be a Duration, e.g.: "2m", "6h", "1d"
Duration string `json:"duration,omitempty" protobuf:"bytes,1,opt,name=duration"`
}

Expand Down
5 changes: 3 additions & 2 deletions pkg/plugins/executor/swagger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3908,8 +3908,9 @@ definitions:
predetermined point in time
properties:
duration:
description: Duration is the seconds to wait before automatically resuming
a template
description: |-
Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds.
Could also be a Duration, e.g.: "2m", "6h", "1d"
type: string
type: object
Synchronization:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ SuspendTemplate is a template subtype to suspend a workflow at a predetermined p

Name | Type | Description | Notes
------------ | ------------- | ------------- | -------------
**duration** | **String** | Duration is the seconds to wait before automatically resuming a template | [optional]
**duration** | **String** | Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds. Could also be a Duration, e.g.: \&quot;2m\&quot;, \&quot;6h\&quot;, \&quot;1d\&quot; | [optional]



Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6f76934

Please sign in to comment.