feat(ui): Add cost optimisation nudges. #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
commented
May 22, 2020
|
Can be merge as soon as appoved. |
simster7
reviewed
May 26, 2020
|
|
||
| private close() { | ||
| this.setState({closed: true}); | ||
| localStorage.setItem(this.key, '{}'); |
There was a problem hiding this comment.
Nice, was curious as to how you would persist the closure.
ui/src/models/workflows.ts
Outdated
Comment on lines
806
to
808
| activeDeadlineSeconds?: number; | ||
| ttlStrategy?: {}; | ||
| podGC?: {}; |
There was a problem hiding this comment.
Could we add the docstrings to these fields as well? We've done a good job of keeping this interface documented so far
| } | ||
| return ( | ||
| <CostOptimisationNudge name='workflow'> | ||
| You do not have {recommendations.join('/')} enabled for this workflow. Enabling these will reduce your costs. |
There was a problem hiding this comment.
I think a link to the cost optimization docs here would be invaluable. I think we should wait until #2972 is merged and add the permalink to the doc here.
There was a problem hiding this comment.
contains that - so this PR depends on that PR
ui/src/app/workflows/components/workflows-list/workflows-list.tsx
Outdated
Show resolved
Hide resolved
1 task
This was referenced Nov 17, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Depends on #2972.
See #2190.
Changes
If there are >100 complete or >100 incomplete workflows, show this on the workflow list:
If a workflow does not have activeDeadlineSeconds/ttlStrategy/podGC, show this is the workflow details:
Both can be dismissed.