UI: 3.5 list view warns about 500 succeeded archived workflows

[tooptoop4]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

after upgrading to v3.5.1 the workflows page shows warning about 500 succeeded workflows

Version

3.5.1

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

n/a

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

[agilgur5]

after upgrading to v3.5.1 the workflows page shows warning about 500 succeeded workflows

I'm not sure what you're referring to. You didn't provide any details beyond this and "500 succeeded workflows" doesn't pop up in a search on the codebase. It's a vague description without a screenshot either -- an exact quote and a screenshot would be very helpful. I personally haven't seen such a warning before either.

We would also need details as to why this behavior is a "bug" and why it is incorrect behavior. Something new or different is not necessarily buggy.

Same as I wrote in one of your other issues: In general, more details are almost always better than few details, which is why they are asked for in issue templates. A one-liner generally does not help much with diagnosis. See also https://stackoverflow.com/help/how-to-ask, https://stackoverflow.com/help/minimal-reproducible-example

[agilgur5]

The only thing I can think you were referring to you is the Cost Optimization nudge that says: "You have at least {counts.incomplete} incomplete, and {counts.complete} complete workflows. Reducing these amounts will reduce your costs.".

That nudge only appears if you have >100 of either incomplete or complete Workflows. It's existed for at least 3 years since Argo v2.9 as well (added by #3089) and has not changed since. That isn't a bug, but is maybe a feature you don't see often.

[tooptoop4]

that sounds like the message but 3.4.11 was NOT affected as workflows UI would only show unarchived (which had less than 500) and the archived UI did not show this message. but with 3.5.1 having both together it shows, which is another alert for users to worry about

[agilgur5]

Ah, I see, yea that seems like an oversight on the implementation of the unified Live + Archived API in #11121. The API was changed but this part of the UI was not.

I'll need to check the old Archived UI, but I don't think Archived Workflows were meant to be included in that count, since it's about GC, which is primarily about etcd, not about the Archive DB (although that too could be cost optimized). EDIT: No they weren't. The CostOptimisationNudge component links to the Cost Optimization docs, which specifically mentions using the Workflow Archive as one way to reduce costs.