Skip to content

Conversation

@blkperl
Copy link
Member

@blkperl blkperl commented Feb 20, 2025

Motivation

adds support for K8s 1.32, potentially drops support for K8s 1.29 which is EOL

Modifications

  • updated go.mod and makefile with new k8s and controller-runtime version

Verification

e2e will verify

Documentation

Docs are not needed

Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
@blkperl blkperl marked this pull request as ready for review February 20, 2025 06:05
@blkperl
Copy link
Member Author

blkperl commented Feb 26, 2025

/retest

# recurl will only fetch if the file doesn't exist, so delete it
rm -f $@
./hack/recurl.sh $@ https://raw.githubusercontent.com/kubernetes/kubernetes/v1.31.3/api/openapi-spec/swagger.json
./hack/recurl.sh $@ https://raw.githubusercontent.com/kubernetes/kubernetes/v1.32.2/api/openapi-spec/swagger.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it makes sense if this be derived from https://github.com/argoproj/argo-workflows/blob/main/hack/k8s-versions.sh?

Not necessary for this PR, but something to consider.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not because thats for the CI version and we will probably update the CI and k8s libs separately

@Joibel Joibel enabled auto-merge (squash) February 27, 2025 11:04
@Joibel Joibel merged commit f2ac4cb into argoproj:main Feb 27, 2025
31 checks passed
@Joibel
Copy link
Member

Joibel commented Feb 27, 2025

Thanks for keeping on top of these @blkperl

Joibel pushed a commit that referenced this pull request Apr 24, 2025
Signed-off-by: William Van Hevelingen <william.vanhevelingen@acquia.com>
(cherry picked from commit f2ac4cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants