ci: drop support for k8s 1.29 and centralize config #14196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Kubernetes Compatibility Matrix` table at https://argo-workflows.readthedocs.io/en/latest/releases/ is misleading, since it isn't actually representing what versions are being tested ([Slack conversation](https://cloud-native.slack.com/archives/C0510EUH90V/p1732621744050569)). This makes it so that table is autogenerated for every release branch, while for `latest` it'll show a message telling the user to switch to a version. That's identical to what ArgoCD is currently doing, e.g.: * https://argo-cd.readthedocs.io/en/latest/operator-manual/installation/#tested-versions * https://argo-cd.readthedocs.io/en/release-2.9/operator-manual/installation/#tested-versions See argoproj/argo-cd#14180 for the corresponding PR on Argo CD, which is what I based this on, but I made several simplifications (e.g. instead of using switching to old release branches in `supported-versions.sh`, I had it just use `git grep` to directly extract the relevant version data). I also updated `.devcontainer/pre-build.sh` to use the same `hack/k8s-versions.sh` script for determining the k3d version, which eliminates the need to update that file when upgrading Kubernetes. Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Joibel
approved these changes
Feb 17, 2025
Member
Joibel
left a comment
Joibel
left a comment
There was a problem hiding this comment.
This needs a fixup, but looks good to me.
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Joibel
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This drops support for Kubernetes 1.29, which will be end-of-life in 2 weeks (https://endoflife.date/kubernetes). This will allow us to take advantage of new features in 1.30, like
ValidatingAdmissionPolicies(#14045). See #14142 (comment) for previous discussions.Also, I centralized the config for defining the tested Kubernetes versions so that we don't duplicate that in both
ci-build.yamlandpre-build.sh.Modifications
Copied the config changes from #14176 and bumped the
minversion inhack/k8s-versions.sh.An alternative to
hack/k8s-version.shwould be to move all the logic for installingk3d/k3s/kubectlinto theMakefileand then defining versions there, which would arguably be cleaner, but that'd require a lot more changes.Verification
Rebuilt DevContainer and verified everything came up successfully:
Documentation
Docs changes will be handled in #14176