docs: list tested Kubernetes versions (#12276) #14180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crenshaw-dev
force-pushed
the
tested-kubernetes-versions
branch
from
e7589dc to
bdb021a
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #14180 +/- ##
=======================================
Coverage 49.60% 49.61%
=======================================
Files 256 256
Lines 43829 43829
=======================================
+ Hits 21741 21744 +3
+ Misses 19950 19948 -2
+ Partials 2138 2137 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> remove crud Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> remove crud Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> so-called readability Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> workflow Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> docs: list tested Kubernetes versions (argoproj#12276) Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> remove crud Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> remove crud Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> so-called readability Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> workflow Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> stash Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> git yay Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> stash Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> pop at the right moment Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> add Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> changes Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> fix oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
force-pushed
the
tested-kubernetes-versions
branch
from
bdb021a to
dd8fedc
Compare
aroramrinaal
approved these changes
Jun 23, 2023
Member
Author
|
/cherry-pick release-2.7 |
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
remove crud remove crud so-called readability workflow docs: list tested Kubernetes versions (argoproj#12276) remove crud remove crud so-called readability workflow stash git yay stash pop at the right moment add changes changes changes fix oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
remove crud remove crud so-called readability workflow docs: list tested Kubernetes versions (argoproj#12276) remove crud remove crud so-called readability workflow stash git yay stash pop at the right moment add changes changes changes fix oops Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
MasonM
added a commit
to MasonM/argo-workflows
that referenced
this pull request
Feb 11, 2025
The `Kubernetes Compatibility Matrix` table at https://argo-workflows.readthedocs.io/en/latest/releases/ is misleading, since it isn't actually representing what versions are being tested ([Slack conversation](https://cloud-native.slack.com/archives/C0510EUH90V/p1732621744050569)). This makes it so that table is autogenerated for every release branch, while for `latest` it'll show a message telling the user to switch to a version. That's identical to what ArgoCD is currently doing, e.g.: * https://argo-cd.readthedocs.io/en/latest/operator-manual/installation/#tested-versions * https://argo-cd.readthedocs.io/en/release-2.9/operator-manual/installation/#tested-versions See argoproj/argo-cd#14180 for the corresponding PR on Argo CD, which is what I based this on, but I made several simplifications (e.g. instead of using switching to old release branches in `supported-versions.sh`, I had it just use `git grep` to directly extract the relevant version data). I also updated `.devcontainer/pre-build.sh` to use the same `hack/k8s-versions.sh` script for determining the k3d version, which eliminates the need to update that file when upgrading Kubernetes. Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12276
Demo: https://github.com/crenshaw-dev/argo-cd/pull/19/files#diff-4ab2c3ee7a77d52cc08fc2cc29333bb3b970adb5cc69bbd185a3b596c5305ad6