Skip to content

chore(deps)!: bump k8s dependencies to 1.31 #13944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Joibel merged 7 commits into from
Dec 5, 2024
Merged

chore(deps)!: bump k8s dependencies to 1.31 #13944

Joibel merged 7 commits into from
Dec 5, 2024

Conversation

@blkperl
Copy link
Member

@blkperl blkperl commented Nov 26, 2024 •
edited
Loading

Motivation

  • adds support for K8s 1.31, potentially drops support for K8s 1.28 which is EOL

Modifications

  • updated go.mod to k8s 1.31 and dependencies
  • updated dist/kubernetes.swagger.json version to 1.31
  • updated from controller-gen@v0.15.0 to controller-gen@v0.16.5
  • changed HandleCrash to HandleCrashWithContext where needed
  • changed RateLimitingInterface to TypedRateLimitingInterface[string]
  • change wait.Until to wait.UntilWithContext

Verification

E2E tests will verify

@blkperl
chore(deps)!: bump k8s dependencies to 1.31
b024b39 
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
@blkperl blkperl added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Nov 26, 2024
@MasonM
chore(deps): fix deprecation errors after upgrade
05e7c82 
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
@blkperl blkperl marked this pull request as ready for review November 28, 2024 16:29
MasonM
MasonM approved these changes Dec 3, 2024
View reviewed changes
blkperl and others added 4 commits December 3, 2024 07:33
@blkperl
fix: apply feedback
0512faa 
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
@blkperl
Merge branch 'main' into k8s_1.31
b42b58f
@blkperl
fix: apply feedback
0c9632f 
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
@blkperl
fix: test missed in the prior commit
97d75d1 
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
Joibel
Joibel approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as always

@Joibel Joibel merged commit de10e06 into argoproj:main Dec 5, 2024
28 checks passed
@blkperl blkperl deleted the k8s_1.31 branch December 5, 2024 16:03
Joibel pushed a commit that referenced this pull request Apr 24, 2025
@blkperl @MasonM @Joibel
chore(deps)!: bump k8s dependencies to 1.31 (#13944)
4e3d5f3 
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Co-authored-by: Mason Malone <651224+MasonM@users.noreply.github.com>
(cherry picked from commit de10e06)
@Joibel Joibel mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasonM MasonM MasonM approved these changes

@Joibel Joibel Joibel approved these changes

Assignees

No one assigned

Labels

go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blkperl @MasonM @Joibel