fix: optimise pod finalizers with merge patch and resourceVersion #13776
+117
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r sync cron Signed-off-by: 刘达 <liuda1@kingsoft.com>
Signed-off-by: 刘达 <liuda1@kingsoft.com>
Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, remove unused code Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, remove unused code Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, rollback environment variables docs Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, optimise codes and logics Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, fix lint error Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, optimise codes Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, add nil finalaizers check Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, update slices compare method Signed-off-by: 刘达 <liuda1@kingsoft.com>
…, fix CI test Signed-off-by: 刘达 <liuda1@kingsoft.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: 刘达 <708988814@qq.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: 刘达 <708988814@qq.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: 刘达 <708988814@qq.com>
Signed-off-by: Alan Clucas <alan@clucas.org>
Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
changed the title
|
@Joibel You can takeover and merge this PR into main, I will close that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #12862 merged in to main and fixed for latest linter. See that PR for commentary.
All credit to @imliuda