refactor: remove util/slice
and use standard slices
library
#13775
+19
−105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
/util/slices
can be replaced by the official slices library added in go 1.21. This library is also the official version ofgolang.org/x/exp/slices
.Replace all uses of these libraries with slices
Modifications
Replace
slice.ContainsString()
withslices.Contains()
. This is very simple.Replace
slice.RemoveString()
withslices.DeleteFunc()
, which involves a small inline boolean comparison function.RemoveString
returned a copy of the slice,DeleteFunc
modifies the slice in place. In the one case where we're using RemoveString to clone the slice (getPodCleanupPatch
),slices.Clone()
it before modifying.Also fix a test name with a spelling mistake.
Verification
Test suite to catch the problems