feat: add support for multi user approval in suspend. fixes #12108

docs/executor_swagger.md

@@ -3515,6 +3515,7 @@ otherwise).
 
 | Name | Type | Go type | Required | Default | Description | Example |
 |------|------|---------|:--------:| ------- |-------------|---------|
+| approvers | []string| `[]string` |  | | List of approvers emails that are required to review the workflow before lifting the suspend.</br>TODO: define minimum length of at least 1 |  |
 | duration | string| `string` |  | | Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds.</br>Could also be a Duration, e.g.: "2m", "6h" |  |
 
 

docs/fields.md

@@ -851,6 +851,7 @@ WorkflowStatus contains overall status information about a workflow
 ### Fields
 | Field Name | Field Type | Description   |
 |:----------:|:----------:|---------------|
+|`approversStatus`|`Map< boolean , string >`|Approvers list for Suspend state|
 |`artifactGCStatus`|[`ArtGCStatus`](#artgcstatus)|ArtifactGCStatus maintains the status of Artifact Garbage Collection|
 |`artifactRepositoryRef`|[`ArtifactRepositoryRefStatus`](#artifactrepositoryrefstatus)|ArtifactRepositoryRef is used to cache the repository to use so we do not need to determine it everytime we reconcile.|
 |`compressedNodes`|`string`|Compressed and base64 decoded Nodes map|
@@ -3173,6 +3174,7 @@ SuspendTemplate is a template subtype to suspend a workflow at a predetermined p
 ### Fields
 | Field Name | Field Type | Description   |
 |:----------:|:----------:|---------------|
+|`approvers`|`Array< string >`|List of approvers emails that are required to review the workflow before lifting the suspend.|
 |`duration`|`string`|Duration is the seconds to wait before automatically resuming a template. Must be a string. Default unit is seconds. Could also be a Duration, e.g.: "2m", "6h"|
 
 ## LabelValueFrom

pkg/apiclient/argo-kube-workflow-service-client.go

@@ -84,6 +84,10 @@ func (c *argoKubeWorkflowServiceClient) SetWorkflow(ctx context.Context, req *wo
 	return c.delegate.SetWorkflow(ctx, req)
 }
 
+func (c *argoKubeWorkflowServiceClient) ApproveWorkflow(ctx context.Context, req *workflowpkg.WorkflowApproveRequest, _ ...grpc.CallOption) (*v1alpha1.Workflow, error) {
+	return c.delegate.ApproveWorkflow(ctx, req)
+}
+
 func (c *argoKubeWorkflowServiceClient) TerminateWorkflow(ctx context.Context, req *workflowpkg.WorkflowTerminateRequest, _ ...grpc.CallOption) (*v1alpha1.Workflow, error) {
 	return c.delegate.TerminateWorkflow(ctx, req)
 }

pkg/apiclient/error-translating-workflow-service-client.go

@@ -71,6 +71,11 @@ func (c *errorTranslatingWorkflowServiceClient) SetWorkflow(ctx context.Context,
 	return workflow, grpcutil.TranslateError(err)
 }
 
+func (c *errorTranslatingWorkflowServiceClient) ApproveWorkflow(ctx context.Context, in *workflowpkg.WorkflowApproveRequest, opts ...grpc.CallOption) (*v1alpha1.Workflow, error) {
+	workflow, err := c.delegate.ApproveWorkflow(ctx, in)
+	return workflow, grpcutil.TranslateError(err)
+}
+
 func (c *errorTranslatingWorkflowServiceClient) StopWorkflow(ctx context.Context, req *workflowpkg.WorkflowStopRequest, _ ...grpc.CallOption) (*v1alpha1.Workflow, error) {
 	workflow, err := c.delegate.StopWorkflow(ctx, req)
 	return workflow, grpcutil.TranslateError(err)

pkg/apiclient/http1/workflow-service-client.go

@@ -82,6 +82,11 @@ func (h WorkflowServiceClient) SetWorkflow(ctx context.Context, in *workflowpkg.
 	return out, h.Put(ctx, in, out, "/api/v1/workflows/{namespace}/{name}/set")
 }
 
+func (h WorkflowServiceClient) ApproveWorkflow(ctx context.Context, in *workflowpkg.WorkflowApproveRequest, _ ...grpc.CallOption) (*wfv1.Workflow, error) {
+	out := &wfv1.Workflow{}
+	return out, h.Put(ctx, in, out, "/api/v1/workflows/{namespace}/{name}/approve")
+}
+
 func (h WorkflowServiceClient) LintWorkflow(ctx context.Context, in *workflowpkg.WorkflowLintRequest, _ ...grpc.CallOption) (*wfv1.Workflow, error) {
 	out := &wfv1.Workflow{}
 	return out, h.Post(ctx, in, out, "/api/v1/workflows/{namespace}/lint")

pkg/apiclient/offline-workflow-service-client.go

@@ -70,6 +70,10 @@ func (o OfflineWorkflowServiceClient) SetWorkflow(context.Context, *workflowpkg.
 	return nil, OfflineErr
 }
 
+func (o OfflineWorkflowServiceClient) ApproveWorkflow(context.Context, *workflowpkg.WorkflowApproveRequest, ...grpc.CallOption) (*wfv1.Workflow, error) {
+	return nil, OfflineErr
+}
+
 func (o OfflineWorkflowServiceClient) LintWorkflow(_ context.Context, req *workflowpkg.WorkflowLintRequest, _ ...grpc.CallOption) (*wfv1.Workflow, error) {
 	err := validate.ValidateWorkflow(o.namespacedWorkflowTemplateGetterMap.GetNamespaceGetter(req.Namespace), o.clusterWorkflowTemplateGetter, req.Workflow, validate.ValidateOpts{Lint: true})
 	if err != nil {