feat: add support for multi user approval in suspend. fixes #12108

[rvandernoort]

Fixes #12108

Motivation

This feature adds support for multi approval in the suspend state instead of using the self-declared single-point enum strategy. This allows for better interactivity and fine-grained access to promotions for instance.

I'm publishing this already now as I am looking to catch some early feedback as this is my first time contributing to this project. This is also one of my first larger PRs (in Go) so I appreciate any feedback that you can provide me and I will try to address any comments as quickly and thoroughly as possible.

Modifications

Currently, the state of this PR is as follows:

• introduce core including ApproverStatus field, an approve function, and two core test cases.
• add ui changes to handle approvals
• handle approvals
  • Currently functionality only accepts approval of your logged in account (in blue) (however this is hardcoded and untested)
• use accounts instead of email string
  • (how do I do this correctly and how do I test it? I tried to use any auth method using the devcontainer but didn't manage to get it working.)
• change timestamp to approved timestamp once approval is complete
• cli cmds?

Screenshots

Single approval

Multi approval

Verification

• unit tests
  • single approval
  • multi approval
  • missing approval (not working, could use help if even possible)
• e2e tests
  • tbd... (suggestions welcome)

[rvandernoort]

Managed to get the core functionality working and looking pretty decent I think. However, I'm a bit stuck on authentication and linking the approvals to users or groups. Would appreciate some help if anyone is able.

[agilgur5]

However, I'm a bit stuck on authentication and linking the approvals to users or groups.

This can be done in the API, but the current approach is insecure in a few ways by relying on status. I detailed this more in the issue: #12108 (comment)

If you just want to implement a UI flow with auth only done there, I would suggest making a UI plugin for this #6945