fix: only set ARGO_PROGRESS_FILE if self reporting progress. Partial fix for #13089
#13135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joibel
added
the
problem/more information needed
|
You need to get the issues with your PRs sorted as per #13131 (review). https://github.com/argoproj/argoproj/blob/main/community/CONTRIBUTING.md describes how to get the DCO signing to work. If you're struggling with what to do, please reach out to me in CNCF slack (as Alan Clucas) and I'll be happy to help. |
|
This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs. |
github-actions
bot
added
the
problem/stale
|
This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open. |
|
Replaced by #13743 |
agilgur5
added
solution/superseded
agilgur5
changed the title
ARGO_PROGRESS_FILE if self reporting progress. Partial fix for #13089
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes point 5 of #13089