Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SKIP_WORKFLOW_DURATION_ESTIMATION. Fixes #7271 #13131

Closed
wants to merge 3 commits into from
Closed

feat: SKIP_WORKFLOW_DURATION_ESTIMATION. Fixes #7271 #13131

wants to merge 3 commits into from

Conversation

tooptoop4
Copy link
Contributor

Fixes #7271
credit to @talebzeghmi

@agilgur5
Copy link
Member

agilgur5 commented May 31, 2024 •
edited
Loading

Apparently this is from zillow#1 -- please cite the source, not only credit the author.

Also please fill out the PR template, it's there for a reason...

agilgur5
agilgur5 reviewed May 31, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, every single one of your PRs fail CI... PRs will not be merged if they fail CI. Period.

Please follow OSS projects' contributing guidelines, PR templates, etc. They are there for a reason, do not ignore them.

@agilgur5 agilgur5 added area/controller Controller issues, panics problem/more information needed Not enough information has been provide to diagnose this issue. labels May 31, 2024
@Joibel Joibel mentioned this pull request Jun 3, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity and needs further changes. It will be closed if no further activity occurs.

@github-actions github-actions bot added the problem/stale This has not had a response in some time label Jun 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been closed due to inactivity and lack of changes. If you would like to still work on this PR, please address the review comments and re-open.

@github-actions github-actions bot closed this Jun 30, 2024
@tooptoop4 tooptoop4 mentioned this pull request Jul 23, 2024
Closed
4 tasks
@agilgur5
Copy link
Member

Replaced by #13745

@agilgur5 agilgur5 changed the title feat: SKIP_WORKFLOW_DURATION_ESTIMATION feat: SKIP_WORKFLOW_DURATION_ESTIMATION. Fixes #7271 Oct 12, 2024
@agilgur5 agilgur5 added solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) and removed problem/stale This has not had a response in some time problem/more information needed Not enough information has been provide to diagnose this issue. labels Oct 12, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agilgur5 agilgur5 agilgur5 left review comments

Assignees
No one assigned
Labels
area/controller Controller issues, panics solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to skip workflow duration estimation
2 participants
@tooptoop4 @agilgur5