-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: documentation links #12446
Merged
terrytangyuan
merged 1 commit into
argoproj:main
from
jmeridth:jm-fix-doc-links-stable-to-latest
Jan 2, 2024
Merged
fix: documentation links #12446
terrytangyuan
merged 1 commit into
argoproj:main
from
jmeridth:jm-fix-doc-links-stable-to-latest
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrytangyuan
approved these changes
Jan 2, 2024
Fixes argoproj#12444 Current links have prefix https://argo-workflows.readthedocs.io/en/stable/ (from argoproj#12360 merge) Expected: Link suffix should be https://argo-workflows.readthedocs.io/en/latest/ since that is what main branch is, it is latest and it is what we are redirecting all old GitHub pages to (from argoproj#12443 merge) Signed-off-by: jmeridth <jmeridth@gmail.com>
auto-merge was automatically disabled
January 2, 2024 22:25
Head branch was pushed to by a user without write access
jmeridth
force-pushed
the
jm-fix-doc-links-stable-to-latest
branch
from
January 2, 2024 22:25
7f701a2
to
8251261
Compare
hittingray
pushed a commit
to atlassian-forks/argo-workflows
that referenced
this pull request
Jan 3, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
agilgur5
reviewed
Feb 8, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12444
Motivation
Current links have prefix https://argo-workflows.readthedocs.io/en/stable/ (from #12360 merge)
Expected:
Link suffix should be https://argo-workflows.readthedocs.io/en/latest/ since that is what main branch is, it is latest and it is what we are redirecting all old GitHub pages to (from #12443 merge)
Where we switched stable to latest
Modifications
Change doc links to latest readthedocs instead of stable (for main)
Verification