Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation links #12446

Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Jan 2, 2024

Fixes #12444

Motivation

Current links have prefix https://argo-workflows.readthedocs.io/en/stable/ (from #12360 merge)

Expected:

Link suffix should be https://argo-workflows.readthedocs.io/en/latest/ since that is what main branch is, it is latest and it is what we are redirecting all old GitHub pages to (from #12443 merge)

Where we switched stable to latest

Modifications

Change doc links to latest readthedocs instead of stable (for main)

Verification

@jmeridth jmeridth self-assigned this Jan 2, 2024
@terrytangyuan terrytangyuan enabled auto-merge (squash) January 2, 2024 22:20
Fixes argoproj#12444

Current links have prefix https://argo-workflows.readthedocs.io/en/stable/ (from argoproj#12360 merge)

Expected:

Link suffix should be https://argo-workflows.readthedocs.io/en/latest/ since that is what main branch is, it is latest and it is what we are redirecting all old GitHub pages to (from argoproj#12443 merge)

Signed-off-by: jmeridth <jmeridth@gmail.com>
auto-merge was automatically disabled January 2, 2024 22:25

Head branch was pushed to by a user without write access

@jmeridth jmeridth force-pushed the jm-fix-doc-links-stable-to-latest branch from 7f701a2 to 8251261 Compare January 2, 2024 22:25
@terrytangyuan terrytangyuan merged commit d1cae63 into argoproj:main Jan 2, 2024
27 checks passed
hittingray pushed a commit to atlassian-forks/argo-workflows that referenced this pull request Jan 3, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
@agilgur5 agilgur5 added the area/docs Incorrect, missing, or mistakes in docs label Jan 4, 2024
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 28, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Mar 12, 2024
Signed-off-by: jmeridth <jmeridth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation links in main are broken
3 participants