Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation links in main are broken #12444

Closed
3 tasks done
jmeridth opened this issue Jan 2, 2024 · 1 comment · Fixed by #12446
Closed
3 tasks done

Documentation links in main are broken #12444

jmeridth opened this issue Jan 2, 2024 · 1 comment · Fixed by #12446
Assignees
@jmeridth
Labels
area/docs Incorrect, missing, or mistakes in docs type/bug

Comments

@jmeridth
Copy link
Member

jmeridth commented Jan 2, 2024

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

Actual:

Current links have prefix https://argo-workflows.readthedocs.io/en/stable/ (from #12360 merge)

Expected:

Link suffix should be https://argo-workflows.readthedocs.io/en/latest/ since that is what main branch is, it is latest and it is what we are redirecting all old GitHub pages to (from #12443 merge)

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

Not relevant

Logs from the workflow controller

Not relevant

Logs from in your workflow's wait container

Not relevant
@jmeridth jmeridth self-assigned this Jan 2, 2024
@jmeridth jmeridth added the area/docs Incorrect, missing, or mistakes in docs label Jan 2, 2024
@jmeridth
Copy link
Member Author

jmeridth commented Jan 2, 2024

#12362 (comment)

jmeridth added a commit to jmeridth/argo-workflows that referenced this issue Jan 2, 2024
@jmeridth
fix: documentation links
7f701a2 
Fixes argoproj#12444

Current links have prefix https://argo-workflows.readthedocs.io/en/stable/ (from argoproj#12360 merge)

Expected:

Link suffix should be https://argo-workflows.readthedocs.io/en/latest/ since that is what main branch is, it is latest and it is what we are redirecting all old GitHub pages to (from argoproj#12443 merge)

Signed-off-by: jmeridth <jmeridth@gmail.com>
@jmeridth jmeridth mentioned this issue Jan 2, 2024
Merged
jmeridth added a commit to jmeridth/argo-workflows that referenced this issue Jan 2, 2024
@jmeridth
fix: documentation links
8251261 
Fixes argoproj#12444

Current links have prefix https://argo-workflows.readthedocs.io/en/stable/ (from argoproj#12360 merge)

Expected:

Link suffix should be https://argo-workflows.readthedocs.io/en/latest/ since that is what main branch is, it is latest and it is what we are redirecting all old GitHub pages to (from argoproj#12443 merge)

Signed-off-by: jmeridth <jmeridth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmeridth jmeridth

Labels
area/docs Incorrect, missing, or mistakes in docs type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: documentation links jmeridth/argo-workflows
1 participant
@jmeridth