build: fix ARGO_LOG_LEVEL
-> ARGO_LOGLEVEL
#11978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kitproj/kit#41 and fixes the issue in this comment: #11879 (comment)
Motivation
credit to Julie and Alex for debugging this, I merely confirmed the issue and fixed it
the flag is
loglevel
and with the automatic env prefix, that becomesARGO_LOGLEVEL
as an env varARGO_LOG_LEVEL
was a misconfiguration / typo as suchModifications
Find+Replace all instances of
ARGO_LOG_LEVEL
->ARGO_LOGLEVEL
Makefile
and thetasks.yaml
also add
watch
list for theui-deps
task after my dive intotask
(this line from build: replacekit
withtask
#11928)kit
kept re-installing deps when this was missingkit
might be missing this feature? 🤔 not sure as the docs are unclear here: Disable watch option kitproj/kit#40 (comment) / "Memoization" / work avoidance / don't run task if sources haven't changed kitproj/kit#46. this change may end up just having it auto-restart when deps change, which is still a good changeui/node_modules
was removed here, as that caused an infinite restart loop when there was a dep changeVerification
After setting the env variable in
tasks.yaml
, the Controller is now showing debug logs during akit
run:Notably, I realized that the Server doesn't even take a loglevel. Its parent command,
argo
, does take a loglevel, and so that should be inherited, but it seems like that flag doesn't pass through to Viper to be read as an env variable automatically.That will require further fixes -- a CLI flag, like
--loglevel=debug
, is currently required for the Server as the env var is currently ignored.