Skip to content

Commit

Permalink
build: fix ARGO_LOG_LEVEL -> ARGO_LOGLEVEL
Browse files Browse the repository at this point in the history
- credit to Julie and Alex for debugging this, I merely confirmed the issue and fixed it

- the flag is [`loglevel`](https://github.com/argoproj/argo-workflows/blob/a45afc0c87b0ffa52a110c753b97d48f06cdf166/cmd/workflow-controller/main.go#L54) and with the [automatic env prefix](https://github.com/argoproj/argo-workflows/blob/a45afc0c87b0ffa52a110c753b97d48f06cdf166/cmd/workflow-controller/main.go#L195), that becomes `ARGO_LOGLEVEL` as an env var
  - `ARGO_LOG_LEVEL` was a misconfiguration / typo as such

- also add `watch` list for the `ui-deps` task after my dive into `task`
  - it seemed like `kit` kept re-installing deps when this was missing
  • Loading branch information
agilgur5 committed Oct 10, 2023
1 parent b2e3676 commit d2c3b36
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ endif
grep '127.0.0.1.*postgres' /etc/hosts
grep '127.0.0.1.*mysql' /etc/hosts
ifeq ($(RUN_MODE),local)
env DEFAULT_REQUEUE_TIME=$(DEFAULT_REQUEUE_TIME) ARGO_SECURE=$(SECURE) ALWAYS_OFFLOAD_NODE_STATUS=$(ALWAYS_OFFLOAD_NODE_STATUS) ARGO_LOG_LEVEL=$(LOG_LEVEL) UPPERIO_DB_DEBUG=$(UPPERIO_DB_DEBUG) ARGO_AUTH_MODE=$(AUTH_MODE) ARGO_NAMESPACED=$(NAMESPACED) ARGO_NAMESPACE=$(KUBE_NAMESPACE) ARGO_MANAGED_NAMESPACE=$(MANAGED_NAMESPACE) ARGO_EXECUTOR_PLUGINS=$(PLUGINS) PROFILE=$(PROFILE) kit $(TASKS)
env DEFAULT_REQUEUE_TIME=$(DEFAULT_REQUEUE_TIME) ARGO_SECURE=$(SECURE) ALWAYS_OFFLOAD_NODE_STATUS=$(ALWAYS_OFFLOAD_NODE_STATUS) ARGO_LOGLEVEL=$(LOG_LEVEL) UPPERIO_DB_DEBUG=$(UPPERIO_DB_DEBUG) ARGO_AUTH_MODE=$(AUTH_MODE) ARGO_NAMESPACED=$(NAMESPACED) ARGO_NAMESPACE=$(KUBE_NAMESPACE) ARGO_MANAGED_NAMESPACE=$(MANAGED_NAMESPACE) ARGO_EXECUTOR_PLUGINS=$(PLUGINS) PROFILE=$(PROFILE) kit $(TASKS)
endif

.PHONY: wait
Expand Down
11 changes: 6 additions & 5 deletions tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ metadata:
annotations:
help: |
Install `kit` by following https://github.com/kitproj/kit#install.
Run `kit up` to start argo.
- `env PROFILE=mysql kit up` to start with MySQL.
- `env PROFILE=plugins ARGO_EXECUTOR_PLUGINS=true kit up` to start with plugins.
- `env PROFILE=sso ARGO_AUTH_MODE=sso kit up` to start with SSO.
The app will be up-and-running between 15s and 1m later (if hot compiled or cold).
The app will be up-and-running between 15s and 1m later (if hot compiled or cold).
Any changes made to the source code will be automatically recompiled and the app restarted, typically within a few seconds.
name: argo-workflows
spec:
Expand Down Expand Up @@ -43,7 +43,7 @@ spec:
- ARGO_NAMESPACE=argo
- ARGO_NAMESPACED=true
- ARGO_MANAGED_NAMESPACE=argo
- ARGO_LOG_LEVEL=info
- ARGO_LOGLEVEL=info
- ARGO_REMOVE_PVC_PROTECTION_FINALIZER=true
- ARGO_PROGRESS_PATCH_TICK_DURATION=7s
- DEFAULT_REQUEUE_TIME=1s
Expand All @@ -69,14 +69,15 @@ spec:
- ARGO_SECURE=false
- ARGO_NAMESPACE=argo
- ARGO_NAMESPACED=true
- ARGO_LOG_LEVEL=info
- ARGO_LOGLEVEL=info
- ARGO_AUTH_MODE=hybrid
- ARGO_MANAGED_NAMESPACE=argo
- UPPERIO_DB_DEBUG=1
ports: "2746"
- name: ui-deps
command: yarn install
workingDir: ui
watch: ui/package.json ui/yarn.lock
mutex: downloads
- name: ui
command: yarn start
Expand Down

0 comments on commit d2c3b36

Please sign in to comment.